Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan - receipt thumbnail is not shown due to a cors policy error #39056

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 27, 2024 · 16 comments
Closed
1 of 6 tasks

Scan - receipt thumbnail is not shown due to a cors policy error #39056

lanitochka17 opened this issue Mar 27, 2024 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open a new Gmail account
  2. Click on FAB > request money > Scan > upload a receipt that will not fail
  3. While on the participants page input 2 new email addresses you did not have history with
  4. Confirm the request and wait for the scan to finish
  5. Once the scan has finished open the console and click on the split preview component to open the RHP

Expected Result:

The receipt thumbnail should load

Actual Result:

The receipt thumbnail does not load due to a cors policy error:
Access to fetch at 'https://www.expensify.com/receipts/w_850728b68d65c07f20d99f83e4b91b01ee49d238.jpg.1024.jpg'
from origin 'https://staging.new.expensify.com'/
has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6428631_1711541013387.splitCorsErrorBug.mp4

Wallmart Receipt

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 27, 2024

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@Beamanator
Copy link
Contributor

@kidroca @aimane-chnaif this looks related to our image caching PR - i wonder if there's an isAuthTokenRequired missing somewhere?

@aimane-chnaif
Copy link
Contributor

oh interesting. If so, why is this reported so late? That PR reached production long time ago.

@Beamanator
Copy link
Contributor

Def good questions 🤷 you're right, this could be unrelated

@Beamanator
Copy link
Contributor

Hmm I can't reproduce this issue

@Beamanator
Copy link
Contributor

I haven't been able to reproduce and I can see receipt images everywhere at the moment so I think we can call this NAB for now & keep this open a bit in case applause can reproduce

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Mar 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@Beamanator Beamanator added Daily KSv2 and removed Hourly KSv2 labels Apr 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 4, 2024
@Beamanator Beamanator added retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Bug Something is broken. Auto assigns a BugZero manager. labels Apr 4, 2024
Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

@Beamanator, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Beamanator
Copy link
Contributor

Waiting for applause to re-test to see if this is still a bug or not

@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

@Beamanator @anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@mvtglobally
Copy link

Issue is reproducible during KI retests.

1712519456367.bandicam_2024-04-07_22-48-17-305.mp4

@mvtglobally mvtglobally removed the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Apr 12, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

@Beamanator, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Apr 16, 2024

@Beamanator, @anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@anmurali
Copy link

Waiting for scan to complete. Will update once it does.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 17, 2024
@Beamanator
Copy link
Contributor

i'm gunna guess we can close this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 19, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants