Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST MONDAY] Chat - When navigation to an IOU link with no access, page keeps loading #39090

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 27, 2024 · 9 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4455035
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in in the app
  2. As account A, create an IOU with account B
  3. Navigate to the IOU details page and copy the URL
  4. Log out of Account A
  5. Log in to another account C (can be any)
  6. Paste and navigate to the IOU link from the previously copied

Expected Result:

The IOU modal shows an error that the payment details cannot be found/Or a message that you have no access to this chat

Actual Result:

The page keeps loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6428977_1711559906671.IOUnoaccess.mp4

Bug6428977_1711559906663!IOUnoaccessloadsforever

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 27, 2024
Copy link

melvin-bot bot commented Mar 27, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

lanitochka17 commented Mar 27, 2024

We think that this bug might be related to #vip-vsp

@lanitochka17
Copy link
Author

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@nkdengineer
Copy link
Contributor

My proposal here #38826 (comment) can fix this issue.

@garrettmknight
Copy link
Contributor

Will likely fix in #38826 - popping on hold while we investigate.

@garrettmknight garrettmknight changed the title Chat - When navigation to an IOU link with no access, page keeps loading [HOLD on 38826] Chat - When navigation to an IOU link with no access, page keeps loading Mar 28, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Mar 28, 2024

this should be fixed by #38955 merged recently

Screen.Recording.2024-03-29.at.1.36.15.AM-1.mov

@garrettmknight
Copy link
Contributor

Cool, will test Monday!

@garrettmknight garrettmknight changed the title [HOLD on 38826] Chat - When navigation to an IOU link with no access, page keeps loading [TEST MONDAY] Chat - When navigation to an IOU link with no access, page keeps loading Mar 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@garrettmknight
Copy link
Contributor

Still on me to test.

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2024
@garrettmknight
Copy link
Contributor

Tested, works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants