Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Chat header hidden below app banner after dismissing the device keypad #39156

Closed
1 of 6 tasks
izarutskaya opened this issue Mar 28, 2024 · 9 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+cknov@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open ND staging & log in
  2. Select any chat from LHN - admins, Concierge chat or 1:1 DM
  3. Tap Done button on device keypad to dismiss the keypad
  4. Scroll the conversation page & observe the chat header gets hidden below app banner

Expected Result:

User able to access the chat header (back button, 3 dot menu & user's profile name) after dismissing the device keypad

Actual Result:

Chat header hidden below app banner after dismissing the device keypad

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6429247_1711573442563.RPReplay_Final1711563049.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

@miljakljajic I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the vip-vsb.

@suneox
Copy link
Contributor

suneox commented Mar 28, 2024

The same rootcause with this issue #39061 i'll fix in #39061

@miljakljajic
Copy link
Contributor

@madmax330 do you think this can be worked on externally, and is it truly a DB?

@yuwenmemon yuwenmemon added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Mar 28, 2024
@yuwenmemon yuwenmemon assigned yuwenmemon and unassigned madmax330 Mar 28, 2024
@yuwenmemon yuwenmemon added Daily KSv2 and removed Hourly KSv2 labels Mar 28, 2024
@yuwenmemon
Copy link
Contributor

Thanks @suneox

Agreed @miljakljajic this isn't a deploy blocker.

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@yuwenmemon
Copy link
Contributor

Closing in favor of #39061

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants