Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report #39679

Closed
6 tasks done
m-natarajan opened this issue Apr 5, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

precondition: user a member of a workspace, there are no open reports

  1. Open the app and log in
  2. Tap the FAB > Request money > Distance
  3. Enter the start and end points
  4. Select the workspace chat and request money
  5. Open the report
  6. Tap the distance receipt thumbnail

Expected Result:

The map and the expense details including amount, miles, start and end point, and date are displayed

Actual Result:

Only a map is displayed in the receipt when only one transaction is in the report.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6438408_1712260833726.video_2024-04-04_15-59-19.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this bug might be related to #wave-collect - Release 1

@Christinadobrzyn
Copy link
Contributor

I don't think this is happening anymore. After reproducing the issue once, the distance receipt now shows the receipt details (see video)

2024-04-05_12-33-09.mp4

Also to note: the distance receipt is different from the SmartScan receipt, is that expected?

I'll ask QA to test again.

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Apr 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2024

I could reproduce in staging
image

Copy link

melvin-bot bot commented Apr 5, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@mountiny mountiny changed the title Distance - Only map displayed in distance receipt if only one expense in report [$250] Distance - Only map displayed in distance receipt if only one expense in report Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@nkdengineer
Copy link
Contributor

nkdengineer commented Apr 5, 2024

@mountiny This will be fixed here #39572 cc @robertjchen.

@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2024

@nkdengineer Nice, thanks I have linked the PR to this issue too, can you update the steps to also test for this?

@mountiny mountiny assigned mountiny and allroundexperts and unassigned ntdiary Apr 5, 2024
@kavimuru
Copy link

kavimuru commented Apr 5, 2024

@Christinadobrzyn The issue reproducible in 1.4.60-10

bandicam.2024-04-05.16-59-41-079.mp4

@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2024

fix is being CPed

@mountiny mountiny added the Reviewing Has a PR in review label Apr 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2024

image

Fixed I think we can close as the PR was handled for another issue

@mountiny mountiny closed this as completed Apr 5, 2024
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 5, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title [$250] Distance - Only map displayed in distance receipt if only one expense in report [HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report Apr 8, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 8, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
  • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@allroundexperts] Determine if we should create a regression test for this bug.
  • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants