[$250] [Awaiting Payment 30th April] [Guided Setup] Onboarding - Modal can bn be dismissed by ESC key

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #37733

Action Performed:

1. Go to staging.new.expensify.com/onboarding
2. Press ESC key on the keyboard

Expected Result:

The modal cannot be dismissed by any other method (PR step 6)

Actual Result:

The modal can be dismissed by ESC key on the keyboard (PR step 6 fails)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442279_1712581924401.20240408_210844.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7cb0b309be5d303
• Upwork Job ID: 1783275074523254784
• Last Price Increase: 2024-04-24

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

@flodnv FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mountiny]

I can take over for wave-collect, been helping out Frank with this project and he is ooo

[mountiny]

There is a second PR coming which will actually enable this flow and we need to incorporate this into that pull request, unless its already implemented

I am demoting it from being a blocker, added it to the project and I will follow up to make sure the PR which enabled this onboarding has the correct behaviour

cc @cdOut @filip-solecki

[filip-solecki]

Hi! I am Filip from SWM expert agency and I would like to work on this!

[cdOut]

Hi, I'm Tymoteusz from Software Mansion, the expert agency, and I'd like to take over this issue from Filip.

[trjExpensify]

Hit prod two days ago. Assigning a BZ for @hoangzinh's payout.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7cb0b309be5d303

[melvin-bot]

Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

[miljakljajic]

@hoangzinh please accept the offer and we'll get you paid!

[hoangzinh]

Accepted. Thanks @miljakljajic

[melvin-bot]

@hoangzinh, @miljakljajic, @mountiny, @cdOut, @filip-solecki Huh... This is 4 days overdue. Who can take care of this?

[miljakljajic]

Paid!