[HOLD for payment 2024-05-02] [Guided Setup] [Hold #39687] Onboarding - Font in onboarding flow is cut off when device font size is on the smaller end

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37733
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to device settings and adjust font to smaller size.
2. Launch New Expensify app.
3. Go to Profile > About > Troubleshoot > 'Navigate' button next to Onboarding flow.
4. Go through the flow.
5. Repeat Step 2 to 4 with different font size (smaller end).

Expected Result:

The font will not be cut off when the font size is on the smaller end.

Actual Result:

The font in onboarding flow is cut off when the font size is on the smaller end.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6443108_1712640526243.RPReplay_Final1712640278.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[pecanoro]

This bug is minor and probably not a blocker, so I am going to remove the label. However, we probably want this fixed, so I am going to assign the original author.

@MaciejSWM Will you be fixing some of these minor bugs in a follow-up PR?

[pecanoro]

@mountiny This bug is minor, but it was caused by the onboarding PR. I think ideally, we would want the author to fix it. However, since it's not urgent, should I open it for contributors instead?

[cdOut]

Hi, I'm Tymoteusz from Software Mansion, the expert agency.

This was a styling issue, we've already fixed it as a part of our Onboarding - enabled PR.

Here's a screenshot of this exact spot with the lowest font settings after fixes:

[trjExpensify]

Nice, I've put it on hold and the fix can be verified once merged and deployed.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Onboarding - Stage 2] Onboarding Flow - enabled #39687

If no regressions arise, payment will be issued on 2024-05-02. 🎊

[pecanoro]

Closing, no need to pay!