Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided Setup] Onboarding - Video is not dismissed after refreshing the page #39920

Closed
4 of 6 tasks
izarutskaya opened this issue Apr 9, 2024 · 15 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #37733
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by:

Action Performed:

  1. Go to staging.new.expensify.com/onboarding.
  2. Enter name > Next.
  3. Select an option > Next.
  4. When the video is playing, refresh the page.

Expected Result:

On page refresh the onboarding video disappears, even if user did not close it explicitly (PR step 18).

Actual Result:

After refreshing the page, the onboarding video does not disappear.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6443101_1712638936444.20240409_125921.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 9, 2024
Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 9, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@kadiealexander I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 9, 2024
@mountiny mountiny assigned mountiny and unassigned srikarparsi Apr 9, 2024
@mountiny mountiny moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 9, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 9, 2024

Not a blocker as this is not accessible for the new users, I am helping with this project now so taking over

@Julesssss
Copy link
Contributor

Excellent 👍

@cdOut
Copy link
Contributor

cdOut commented Apr 9, 2024

Hi, I'm Tymoteusz from Software Mansion, the expert agency, and I will work on this issue.

@mountiny mountiny added the Daily KSv2 label Apr 9, 2024
@cdOut
Copy link
Contributor

cdOut commented Apr 10, 2024

I'm working on this, I'll post a solution as a commit in the onboarding flow enabled PR.

@hoangzinh
Copy link
Contributor

I reported this bug during PR review, and it appears that we changed behavior here #37733 (comment)

@cdOut
Copy link
Contributor

cdOut commented Apr 11, 2024

I reported this bug during PR review, and it appears that we changed behavior here #37733 (comment)

@shawnborton Is this still the way we want to go forward with this one? If yes then we can close this issue and if we want to go back to the previous implementation then I have a solution ready to be pushed.

@shawnborton
Copy link
Contributor

Yeah, I thought we decided that refreshing the page is the same as accessing the current page URL, and if the current page url is for showing a video, then it makes sense that refreshing would show the video again. Maybe I am missing something though? Cc @Expensify/design for a gut check, but seems like we can close this one.

@dannymcclain
Copy link
Contributor

Yeah, I thought we decided that refreshing the page is the same as accessing the current page URL, and if the current page url is for showing a video, then it makes sense that refreshing would show the video again. Maybe I am missing something though? Cc @Expensify/design for a gut check, but seems like we can close this one.

Totally agree. I remember us deciding this in Slack. This looks like expected behavior to me and I think we can close.

@dubielzyk-expensify
Copy link
Contributor

I'm aligned with that. We also wanted the potential ability to link to this video which is why this is good as is.

Worth noting that even if people land on this video after having just seen it, there's no real damage in that :)

@kadiealexander
Copy link
Contributor

Agree with everyone here, closing the issue!

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 12, 2024
@trjExpensify trjExpensify changed the title Onboarding - Video is not dismissed after refreshing the page [Guided Setup] Onboarding - Video is not dismissed after refreshing the page Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
No open projects
Archived in project
Development

No branches or pull requests

10 participants