Chat – Unable to open any + menu option using Up keys and Enter, when open it first time

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in.
3. Navigate to any chat
4. Click on + button
5. Navigate via + menu using Up/Down keys and press Enter

Expected Result:

Chosen menu opens

Actual Result:

Nothing happens, unable to open + menu option using Up keys and Enter, when open it first time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453289_1713425271864.Key_menu.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@kadiealexander I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

bandicam.2024-04-18.10-38-52-779.mp4

[NikkiWines]

Interesting, (h/t to @sonialiap for identifying this) this works the second time you press Enter but not the first, and if you navigate to another option (e.g. press enter the first time for splitting a bill, the second for editing a task) it will remember your first selection, not your second (splitting a bill). Definitely a bug 🐛

Screen.Recording.2024-04-18.at.10.26.16.mov

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat – Unable to open any + menu option using Up keys and Enter, when open it first time

What is the root cause of that problem?

Here we call the onItemSelected function before setting the value of selectedItemIndex.current

What changes do you think we should make in order to solve the problem?

Here move the selectedItemIndex.current = index code above the onItemSelected function call

selectedItemIndex.current = index;
onItemSelected(selectedItem, index);

What alternative solutions did you explore? (Optional)

[NikkiWines]

Looks like it might be a result of #39201 cc: @roryabraham @WojtekBoman

[WojtekBoman]

I'll prepare a fix for that :)

[roryabraham]

thanks for identifying the PR that caused this @NikkiWines 🙇🏼

[roryabraham]

verified this is fixed on staging, no payments due, closing it out