[Awaiting payment]Workspace members - Missing Make admin and Make member button in the dropdown menu

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > any workspace.
3. Go to Members tab.
4. Add a few members and promote some to admin.
5. Check non-admin member > Click dropdown menu.
6. Check admin member > Click dropdown menu.

Expected Result:

In Step 5, Make admin option will be present in the dropdown menu (production behavior).
In Step 6, Make member option will be present in the dropdown menu (production behavior).

Actual Result:

In Step 5 and 6, only Remove member option is present in the dropdown menu.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453295_1713425281949.dropdown_menu_member.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@muttmuure I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[MonilBhavsar]

Looking...

[MonilBhavsar]

I think I found the issue, almost there, so working on a fix. Seems to be coming from #39489

[ZhenjaHorbach]

I think I found the issue, almost there, so working on a fix. Seems to be coming from #39489

@MonilBhavsar
Oh
Probably it's from my PR )
Do you need help ?
Or are you already working on a fix?

[MonilBhavsar]

Thanks! I have a draft PR up that fixes this issue https://github.com/Expensify/App/pull/40428/files
I'm checking the file if it caused any other issues and ensuring the workflow is working fine
Feel free to checkout/review

[MonilBhavsar]

@ZhenjaHorbach as you can see in my draft PR, I am using an additional find function to get email from the selected user's accountID. Can you think of more optimistic solution?

[MonilBhavsar]

This is now fixed on staging

[MonilBhavsar]

Assigning @allroundexperts for reviewing and testing the PR

[muttmuure]

Not overdue

[MonilBhavsar]

PR was deployed to production #40428
@muttmuure, we can pay @allroundexperts for reviewing PR and close this

[MonilBhavsar]

Awaiting payment here

[muttmuure]

$250 to @allroundexperts for C+

[JmillsExpensify]

$250 approved for @allroundexperts