[HOLD for payment 2024-05-09] [Wave Collect][QBO] iOS - Accounting - App crashes after completing QBO setup flow

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: No newfeature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to Account settings > Profile > Workspaces.
3. Select any workspace.
4. Go to Accounting tab.
5. Set up with a QBO account.
6. Complete the setup flow.

Expected Result:

App does not crash after completing the setup flow.

Actual Result:

App crashes after completing the setup flow.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453978_1713461681980.RPReplay_Final1713461021__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b9f4742753f04f67
• Upwork Job ID: 1783606664918646784
• Last Price Increase: 2024-04-25

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[roryabraham]

cc @hayata-suenaga @aldo-expensify

[roryabraham]

pinged in slack: https://expensify.slack.com/archives/C036QM0SLJK/p1713481453601659

[roryabraham]

going to check crashlytics

[aldo-expensify]

Yes, this is known, we have to update RN or add a patch. The WebView crashes when it gets unmounted, see https://expensify.slack.com/archives/C01GTK53T8Q/p1712890318658009?thread_ts=1712881940.330269&cid=C01GTK53T8Q

[aldo-expensify]

It only happens in IOS native, it is an bug in react native

[roryabraham]

guessing this is the crash: https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/ios:com.chat.expensify.chat/issues/3b8fa442322377f27ebbc9bcaff958be?time=last-seven-days&types=crash&sessionEventKey=e0225bd13ba04f2197348d57024bd093_1937789363074008983

[aldo-expensify]

I understand that we were going to soon update to RN 0.74, is that still on track?

[roryabraham]

it's not really on track, no

[aldo-expensify]

it's not really on track, no

Then I guess we will need to upgrade to 0.73.5 or add the fix as a patch, do you have any preference? I'm very unfamiliar with fixing RN

[roryabraham]

I think a minor RN upgrade would be much better than adding a patch. But it could be hard if the patches we've already got need to be ported over

[aldo-expensify]

nice, then I'll try the minor RN upgrade first.

Regarding this being a DeployBlocker, I would just remove the label because we knew about this crash and we were planning to work on it later to avoid holding the QBO authentication PR on it. Sounds good? My focus will be on this anyway since this is part of the QBO project scheduled for the spring release.

[roryabraham]

hmmm is QBO behind a beta? I get that it's a new feature but I'd think we wouldn't want to ship it if it crashes the app...

[aldo-expensify]

hmmm is QBO behind a beta?

It is, beta accountingOnNewExpensify

[aldo-expensify]

Need internal review from engineer for #41023 and then merge

[trjExpensify]

Merged!

[aldo-expensify]

niice

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Patch for WebView crash v2 #41023

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rojiphil] Determine if we should create a regression test for this bug.
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Julesssss]

Hey @aldo-expensify (or @roryabraham as you have permission to close issues in Firebase...)

I believe this Firebase crash report matches the WebView crash that was reported in this issue. If the merged PR does resolve the crash can you please mark the firebase issue closed? Thanks!

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @stephanieelliott you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @rojiphil paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1783606664918646784/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

Hey @rojiphil I extended an offer to you for this job on Upwork, can you please accept? https://www.upwork.com/nx/wm/offer/102258379

[rojiphil]

I extended an offer to you for this job on Upwork, can you please accept?

Accepted offer. Thanks

[stephanieelliott]

All paid, thanks @rojiphil!