Android - Distance - A deleted offline waypoint remains in the distance editor after going online

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.63-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4498589
Email or phone of affected tester (no customers): sustinov@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Prerequisites:
Create WS collect, invite an employee.

Step:

1. Open https://staging.new.expensify.com/
2. Log in to the employee account
3. Navigate to a workspace room
4. Create a 2 IOU distance with 3 waypoints
5. Navigate to the last IOU you created
6. Switch off the Internet
7. Change the date and Save
8. Navigate to the waypoint editing menu
9. Delete the last waypoint
10. Save
11. Switch on the internet
12. Return to the Report Conversation
13. Once the IOU is fully registered, go to the waypoint editing menu

Expected Result:

A deleted waypoint in offline should disappear after going online

Actual Result:

A deleted offline waypoint remains in the distance editor after going online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6455058_1713540940761.screencapture-1713540571335.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cbc67100f420bf95
• Upwork Job ID: 1785502891993055232
• Last Price Increase: 2024-06-02
• Automatic offers:
• shubham1206agra | Reviewer | 102965910
• paultsimura | Contributor | 102965911

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Checking on here

I have this issue, which is for Android Native, couple questions
Didn't Browserstack used to automatically load the NewDot app installed each time it loaded?
Are there known issues with Android deploys now? If so, do we want to take any actions based on that? ie. put on hold.

[mallenexpensify]

This is distance related so adding to #wave-collect. Unable to repro cuz app didn't auto-load via browserstack.

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cbc67100f420bf95

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @shubham1206agra (Internal)

[mallenexpensify]

@shubham1206agra , do you have an Android phone and are you able to repro?

[shubham1206agra]

I do have Android phone. I will test this issue in few hours.

[melvin-bot]

@mallenexpensify @shubham1206agra this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[shubham1206agra]

@mallenexpensify Sorry for the delay but I am able to repro the issue on 1.4.69-2.

[mallenexpensify]

Few levels deep here to get to the PR, posted there, bumped to weekly and put on hold (removed help wanted)

• Try to synchronize operations within one update react-native-onyx#490 (comment)

[melvin-bot]

This issue has not been updated in over 15 days. @mallenexpensify, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[shubham1206agra]

This is on hold.

[mallenexpensify]

@paultsimura please comment so I can assign, added to

• [Tracking] Offline Distance issues #44582

[paultsimura]

👋🏼

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[paultsimura]

@mallenexpensify could we please request a re-test on this issue? Looks like it can be closed.

[shubham1206agra]

@mallenexpensify Bump here for retest.

[mallenexpensify]

Added the label, it might take a bit. I don't have a physical android phone so I can't quickly/easily test.

[paultsimura]

@mallenexpensify I'm pretty sure this can be closed. But can we bump for retest so I could get this issue off my list?

[mallenexpensify]

Bumped to daily, made me the owner and requested a retest in the QA channel
https://expensify.slack.com/archives/C9YU7BX5M/p1725410212524379

[mvtglobally]

Issue is not reproducible https://github.com/user-attachments/assets/be89fbad-34e9-45c8-b86c-aa15324d89b3

[mallenexpensify]

Thanks @mvtglobally , closing