Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the header name in Track expense, Submit expense, and Split expense #40615

Closed
kevinksullivan opened this issue Apr 19, 2024 · 4 comments
Closed
Assignees
Labels
Daily KSv2 Reviewing Has a PR in review

Comments

@kevinksullivan
Copy link
Contributor

kevinksullivan commented Apr 19, 2024

As part of the Add split to global create doc, and specifically this section, we are updating the header for the Track expense, Submit expense, and Split expense flows, to keep that title in the header for the whole flow instead of updating the header to show the "type" of track/request/split the person is creating (like manual).

Here is an example from Split, where you'll see the header is Split expense throughout.

image

Let's make this update to each of the mentioned flows.

@shubham1206agra
Copy link
Contributor

Handling the changes in #40576

@mountiny mountiny added the Reviewing Has a PR in review label Apr 20, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

@mountiny, @shubham1206agra, @getusha Eep! 4 days overdue now. Issues have feelings too...

@getusha
Copy link
Contributor

getusha commented Apr 29, 2024

deployed to production last week

@getusha
Copy link
Contributor

getusha commented May 2, 2024

We can close this @mountiny

@mountiny mountiny closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants