Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding - Missing attachment, not here page and skeleton in concierge task page #40715

Closed
6 tasks done
kbecciv opened this issue Apr 22, 2024 · 14 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Apr 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Troubleshooting > Onboarding flow.
  3. Select "Chat and split expenses with friends" > Next.
  4. Enter name > Next.
  5. Go to Concierge chat.
  6. Click on any task.
  7. Select an assignee.

Expected Result:

In Step 5, the attachment will show up in Concierge chat.
In Step 6, in task page, there will not be "Not here" page.
In Step 7, task report will not show skeleton loading after assigning an assignee.

Actual Result:

In Step 5, the attachment is displayed as [Attachmnt] in Concierge chat.
In Step 6, in task page, "Not here" page flickers briefly.
In Step 7, task report shows skeleton loading after assigning an assignee.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457565_1713800765045.onboard.1.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 22, 2024

We think that this bug might be related to #vip-vsb

@mountiny mountiny assigned mountiny and unassigned aldo-expensify Apr 22, 2024
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor

Taking this over cc @rezkiy37 @filip-solecki @cdOut @hoangzinh @rayane-djouah @francoisl from the onboarding initiative

@rayane-djouah
Copy link
Contributor

In Step 5, the attachment is displayed as [Attachmnt] in Concierge chat.

This is expected result, the video will be available after the backend response.

In Step 6, in task page, "Not here" page flickers briefly.

I reported this earlier in the PR, it's a backend bug.

In Step 7, task report shows skeleton loading after assigning an assignee.

This is a backend bug.

@mountiny
Copy link
Contributor

Just merged a backend Pr for this

@mountiny mountiny added the Reviewing Has a PR in review label Apr 23, 2024
@mountiny
Copy link
Contributor

Copy link

melvin-bot bot commented May 1, 2024

@kevinksullivan, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented May 3, 2024

@kevinksullivan, @mountiny Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented May 7, 2024

@kevinksullivan, @mountiny 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

1 similar comment
Copy link

melvin-bot bot commented May 7, 2024

@kevinksullivan, @mountiny 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@kevinksullivan
Copy link
Contributor

Auth PR is merged / depoyed. I think we are done here @mountiny ?

@mountiny
Copy link
Contributor

mountiny commented May 8, 2024

Yep I think this is done

@mountiny mountiny closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants