Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Android - Report - Attempting to save an edited post freezes the app #40723

Closed
1 of 6 tasks
kbecciv opened this issue Apr 22, 2024 · 22 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Apr 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #40547
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open New Expensify app
  2. Navigate the conversation with a large message history
  3. Scroll up the message history
  4. Select any message and go to the thread
  5. Navigate back to the conversation
  6. Scroll up the message history
  7. Select any message and edit it
  8. Send the edited message

Expected Result:

The message modification should be applied immediately when the send button is pressed

Actual Result:

Attempting to save an edited post freezes the app

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457755_1713808568737.screencapture-1713807499708.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0114ce3629e3c33f49
  • Upwork Job ID: 1782501943628816384
  • Last Price Increase: 2024-04-22
Issue OwnerCurrent Issue Owner: @mallenexpensify
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 22, 2024

We think that this bug might be related to #vip-vsb

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0114ce3629e3c33f49

@melvin-bot melvin-bot bot changed the title Android - Report - Attempting to save an edited post freezes the app [$250] Android - Report - Attempting to save an edited post freezes the app Apr 22, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@mountiny
Copy link
Contributor

cc @roryabraham @kosmydel Seems like coming from testing the inverted flatlist issue

@mountiny mountiny changed the title [$250] Android - Report - Attempting to save an edited post freezes the app [$500] Android - Report - Attempting to save an edited post freezes the app Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Upwork job price has been updated to $500

@AndrewGable
Copy link
Contributor

Discussing here: https://expensify.slack.com/archives/C01GTK53T8Q/p1713867912363639

Seems new arch related so we might remove blocker as it seems to be Android only.

@mountiny
Copy link
Contributor

based on the discussion, it seems like the same root cause of the other new arch android issue so removing the blocker

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 23, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 26, 2024
@roryabraham
Copy link
Contributor

@kavimuru
Copy link

Reproduced and freeze can be observed at timeline 2:00

Repro_PR40723.mp4

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 20, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label May 20, 2024
Copy link

melvin-bot bot commented May 20, 2024

This issue has not been updated in over 15 days. @AndrewGable, @akinwale eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week) Good to close?

@AndrewGable
Copy link
Contributor

Yep, good to close.

@mallenexpensify mallenexpensify self-assigned this Jun 5, 2024
@mallenexpensify mallenexpensify added Daily KSv2 and removed Reviewing Has a PR in review Monthly KSv2 labels Jun 5, 2024
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Jun 5, 2024

Reopening per here, assigned to me and made myself the issue owner.
@akinwale , please comment and link to PR you reviewed. Thx

@akinwale
Copy link
Contributor

akinwale commented Jun 5, 2024

@mallenexpensify Here's the PR: #41101

Thanks.

@mallenexpensify mallenexpensify added Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. and removed External Added to denote the issue can be worked on by a contributor labels Jun 5, 2024
Copy link

melvin-bot bot commented Jun 5, 2024

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

@mallenexpensify
Copy link
Contributor

@akinwale can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01d3dfbb6bd39587f3

@akinwale
Copy link
Contributor

akinwale commented Jun 5, 2024

@mallenexpensify Offer accepted. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2024
@mallenexpensify
Copy link
Contributor

Contributor+: @akinwale paid $500 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

8 participants