[PAID] [$250] Scan - Scan expense preview created with PDF file is shown larger than with images

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.64-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4503776
Email or phone of affected tester (no customers): applausetester+vd_ios042224@applause.expensifail.com,
applausetester+vd_web042224@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-requisite: the user must be an employee of a Workspace.

1. Go to Workspace chat.
2. Create 2 money request with the "Scan" option, select any 2 images.
3. Create a 3rd money request with the "Scan" option, but using a PDF file.
4. Verify that the report preview image of the PDF file is shown larger than those with image format.

Expected Result:

The preview of the PDF file should be the same as the image formats.

Actual Result:

The preview of the PDF file is larger than the image formats.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017d201aaa419b0fee
• Upwork Job ID: 1782700594939478016
• Last Price Increase: 2024-05-14
• Automatic offers:
• jjcoffee | Reviewer | 0

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017d201aaa419b0fee

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[mountiny]

Making this external and removing a blocker, this is not blocking users from using the app

[jjcoffee]

@ZhenjaHorbach Thanks, but it seems unlikely given that PR was deployed to production a month ago.

[ZhenjaHorbach]

@ZhenjaHorbach Thanks, but it seems unlikely given that PR was deployed to production a month ago.

Sorry
I didn't notice the date)

[madmax330]

waiting on proposals

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[dominictb]

Melvin chill out :) I'm on other high priority issue. Will come back to this issue in maybe 1-2 days.

[jjcoffee]

PR is up! I will be reviewing tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: customize size behavior of image component #42469

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @dominictb requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@dominictb - can you link me your upwork profile so I can hire you to the job?

@jjcoffee - Feel free to do the checklist when you can and I'll move this forward then.

Thanks all!

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - I couldn't find any specific point where the behaviour was introduced
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Create 2 money requests with the "Scan" option, using any image.
2. Create a 3rd money request with the "Scan" option, but using an A4 PDF file.
3. Verify that the report preview thumbnails are all of the same size, especially the preview of the PDF file.

Do we agree 👍 or 👎

[strepanier03]

@dominictb - I've hired you to a job here, I'll check tomorrow to pay it out.

@jjcoffee - I've paid your contract in Upwork and closed it.

Thank you both!

[melvin-bot]

@madmax330, @strepanier03, @jjcoffee, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Okay, job paid and contract closed. Closing this out thanks all!