Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-03] [Wave Collect][QBO] Update Export Pages for Company Cards to include amendments #40792

Closed
zanyrenney opened this issue Apr 23, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@zanyrenney
Copy link
Contributor

zanyrenney commented Apr 23, 2024

As part of QBO, related to this PR: #40713

Please amend the pages for

Export Company Cards: Debit Card

image

Notes for completeness:

  • Add a new page for Export Company Card expenses as which is navigated to by clicking the `Export Company Cards as’ form menu item on the Export page.
  • Show the subtext for the page ”Set how company card purchases export to QuickBooks Online.”
  • Add a form menu item for Export as with the right caret which opens to a new page Titled Export as.
  • Display the selected export method in the Export as Form Menu item.
  • On the Export as page, show the export methods in the select list pattern, with the selected export method row highlighted with a green checkmark. The options are:
    • Credit card
    • Debit card
    • Vendor bill
  • When Debit card is selected display the subtext on the Export Company Card expenses as page:
    • “We'll automatically match the merchant name on the debit card transaction to any corresponding vendors in QuickBooks. If no vendors exist, we'll create a "Debit Card Misc." vendor for association.”
  • Add an additional Account menu item to choose an applicable account from QBO. The default selected is the first alphabetically in the list of available accounts imported.
  • Create a new page for Account which is clicked to through the form menu item on the Export company cards page.
  • Display the subtext “Debit card transactions will export to the bank account below.””
  • Display the available accounts in the select list pattern, with the selected account row highlighted with a green checkmark.

Export Company Cards: Credit Card

image

  • The default export method for company card expenses upon initializing a connection to QBO is Credit Card
  • When Credit card is selected display the subtext:
    • “We'll automatically match the merchant name on the credit card transaction to any corresponding vendors in QuickBooks. If no vendors exist, we'll create a "Credit Card Misc." vendor for association..”
  • Display the selected Account in the form menu item. The default selected is the first alphabetically in the list of available accounts imported.
  • Create a new page for Credit card account which is clicked to through the form menu item on the Export company cards page and show the available accounts in a select list.

Export Company Cards: Vendor Bill

image

  • When Vendor bill is selected display the subtext:
    • “We'll create a single itemized vendor bill for each Expensify report, carrying the date of the last expense on the report. If this period is closed, we'll post to the 1st of the next open period. You can add the vendor bill to your A/P account of choice (below).”
  • Display the available Accounts payable accounts from the QBO integration. The default selected is the default AP account set in QBO.
  • Display the subtext “Set a default vendor that will apply to all credit card transactions upon export.” with a toggle for enabled/disabled (disabled by default).
  • Under the toggle, display a Vendor push row with the selected vendor account as the value. The first vendor account in QBO alphabetically is selected by default when enabled.
  • Create a new page for Accounts payable which is clicked to through the form menu item on the Export company cards page.
  • Display the subtext “This is your chosen credit card account”
  • Display the accounts in the select list pattern, with the selected account row highlighted with a green checkmark.
  • Create a new page for “Vendor”
  • Add the subtext “Select the vendor applied to all credit card transactions.”
@zanyrenney zanyrenney moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 23, 2024
@narefyev91
Copy link
Contributor

I will pick this up, can you please assign me

Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 23, 2024
@trjExpensify trjExpensify changed the title Amend Export Pages for Company Cards to include amendments [QBO] Update Export Pages for Company Cards to include amendments Apr 23, 2024
@trjExpensify trjExpensify added Monthly KSv2 Daily KSv2 and removed Weekly KSv2 Monthly KSv2 labels Apr 23, 2024
@trjExpensify trjExpensify removed the Task label Apr 23, 2024
@hayata-suenaga hayata-suenaga changed the title [QBO] Update Export Pages for Company Cards to include amendments [Wave Collect][QBO] Update Export Pages for Company Cards to include amendments Apr 23, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Apr 24, 2024
@melvin-bot melvin-bot bot changed the title [Wave Collect][QBO] Update Export Pages for Company Cards to include amendments [HOLD for payment 2024-05-03] [Wave Collect][QBO] Update Export Pages for Company Cards to include amendments Apr 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 26, 2024
Copy link

melvin-bot bot commented Apr 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-03. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 26, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@narefyev91] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 3, 2024
Copy link

melvin-bot bot commented May 3, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@hayata-suenaga
Copy link
Contributor

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Tom, @s77rt did a C+ review for this PR associated with this issue.

@trjExpensify
Copy link
Contributor

Confirming payment summary as follows:

  • $250 to @s77rt for the C+ review

Offer sent!

@s77rt
Copy link
Contributor

s77rt commented May 7, 2024

@trjExpensify Accepted! Can you please make this $125 as I didn't review the full PR (PR got merged before I make another review)

@trjExpensify
Copy link
Contributor

Done!

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants