-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-20] [$250] Workspace - Invite error is not dismissed via X button in the workspace list #40800
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
ProposalPlease re-state the problem that we are trying to solve in this issue.Invite error is not dismissed via X button in the workspace list What is the root cause of that problem?This is not a simple issue: 1- the error message is turned from backend as part of displayes all App/src/pages/workspace/WorkspaceInitialPage.tsx Lines 74 to 77 in d296ef8
What changes do you think we should make in order to solve the problem?1- The backend should turn an error code/string so we can translate 2- The error should be displayed below the members list and not on the left with the menu items 3- Closing the error should only dismiss the message and not remove the workspace onClose={() => clearMembersErrors(); |
Job added to Upwork: https://www.upwork.com/jobs/~0186e1563827cf6717 |
this def seems like a bug. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace - Invite error is not dismissed via X button in the workspace list What is the root cause of that problem?The main problem with issue is that for disable error from Workspace list we use pendingAction from policy As result when we try to close error from WorkspacesListPage nothing happened App/src/pages/workspace/WorkspacesListPage.tsx Lines 339 to 344 in d296ef8
And since we receive an error due to an incorrect user, we need to update the error closure inside the workspace and in the list to just close this error without removing workspace What changes do you think we should make in order to solve the problem?I made implementation only for We can update dismissError like
App/src/pages/workspace/WorkspacesListPage.tsx Lines 339 to 344 in d296ef8
And then update
Plus we need update App/src/libs/actions/Policy.ts Lines 1789 to 1796 in d296ef8
Similar implementation we can make and for error inside workspace initial page App/src/pages/workspace/WorkspaceInitialPage.tsx Lines 74 to 77 in d296ef8
What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.There are 3 issues here, first, the failed member and its error message don't show like before. Second, when we close the invite error message, the policy is removed and we are navigated back to the workspace list. Last, we can't clear the error from workspace list page/ What is the root cause of that problem?For the first problem, we get the member data from
However, Lines 157 to 159 in d296ef8
For the second problem, when closing the error message, we call App/src/pages/workspace/WorkspaceInitialPage.tsx Lines 74 to 77 in d296ef8
For the 3rd problem, if there is no pending action, which is true for our case, we just do nothing. App/src/pages/workspace/WorkspacesListPage.tsx Lines 339 to 344 in 7924597
What changes do you think we should make in order to solve the problem?For the first problem, we can add a new param to App/src/libs/actions/Policy.ts Lines 1403 to 1409 in b8d1908
To fix it, we should iterate over App/src/libs/actions/Policy.ts Line 1389 in b8d1908
we also need to add
In 3rd problem, we already handle the case for add/delete pending action. App/src/pages/workspace/WorkspacesListPage.tsx Lines 105 to 116 in 7924597
To solve the 3rd problem, we will remove the pending action check from the code below. App/src/pages/workspace/WorkspacesListPage.tsx Lines 340 to 343 in 7924597
In App/src/libs/actions/Policy.ts Lines 2503 to 2506 in a852ea7
but it doesn't work because we accessed the key wrongly, it should be
but even if we fix this one, looks like the double merge with a null and empty object doesn't work at all. App/src/libs/actions/Policy.ts Lines 1789 to 1796 in a852ea7
To simplify it, we can just update
To solve the 2nd problem, we will update the
|
Updated proposal to include more fix |
Proposals pending review |
@Santhosh-Sellavel mind reviewing? |
Sorry this one, skipped my list will get to it later today! |
TY! |
Pending review from @Santhosh-Sellavel |
Sorry for the back and forth. I'm Just gonna unassign this as my bandwidth is too low. Asked here for volunteers |
@arosiclair Will takeover this as C+! |
Looks like an auto complete error above. Taking over here as C+. |
📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
PR is ready cc: @akinwale |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@akinwale could you please handle the BZ checklist this week so we can prep for payment? |
bump @akinwale could you please handle BZ here so we can issue payment? |
Not a regression. This was not being specifically handled.
Regression Test Steps
Do we agree 👍 or 👎? |
@joekaufmanexpensify Done! |
Hmm, I feel like this is a pretty niche issue. I feel like it's fine to have no regression test for this. |
Checklist is complete! |
All set to issue payment. We need to pay:
|
@bernhardoj $250 sent and contract ended! |
@akinwale $250 sent and contract ended! |
Upwork job closed. |
All set, TY everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.64-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The error is dimissed
Actual Result:
The error is not dismissed when clicking on X button in the workspace list
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6458809_1713877820690.20240423_210639.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @joekaufmanexpensifyThe text was updated successfully, but these errors were encountered: