[$250] Track expense - Distance is not editable after expense tracking is created

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-0
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #39956
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Self DM.
3. Track a distance expense.
4. Go to expense thread.

Expected Result:

Distance should be editable.

Actual Result:

Distance is not editable.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460028_1713952302545.20240424_174902.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa26b2aab67f7bd8
• Upwork Job ID: 1784826184446623744
• Last Price Increase: 2024-04-29

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

We think that this bug might be related to #vip-vsb

[kbecciv]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cannot edit distance on MoneyRequestView if the report is a Track Expense type.

What is the root cause of that problem?

We have disabled the ability to edit distances in Track Expens by using !isTrackExpense:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 154 to 155 in 9a727de

	// TODO: remove the !isTrackExpense from this condition after this fix: https://github.com/Expensify/Expensify/issues/382786
	const canEditDistance = ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE) && !isTrackExpense;

We also have a note above to remove the extra condition.

What changes do you think we should make in order to solve the problem?

We need to remove the extra condition && !isTrackExpense. This will make the request editable on Track Expense as well

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aa26b2aab67f7bd8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Santhosh-Sellavel]

@kadiealexander Please reassign a new C+ Here. Unassigning due to low availability.

[Santhosh-Sellavel]

@allroundexperts Will take over this as C+!

[kadiealexander]

@allroundexperts could you please review the existing proposals? Thanks!

[neil-marcellini]

This is intentional and will be fixed by this PR, and handled by the related issue [App] [HOLD Web-E 41549] Allow editing distance for tracked expenses