Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIGH: [Live Markdown] [$500] Android - Chat - User unable to select complete sentence #40890

Closed
1 of 6 tasks
kbecciv opened this issue Apr 24, 2024 · 26 comments
Closed
1 of 6 tasks
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65.0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Enter a sentence
  4. Try to select complete sentence

Expected Result:

User must be able to select complete sentence

Actual Result:

User unable to select complete sentence

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460170_1713959074694.text.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017bd806a6be2ddbfd
  • Upwork Job ID: 1783137020323028992
  • Last Price Increase: 2024-04-24
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 0
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented Apr 24, 2024

We think that this bug might be related to #vip-vsb

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Apr 24, 2024
@melvin-bot melvin-bot bot changed the title Android - Chat - User unable to select complete sentence [$250] Android - Chat - User unable to select complete sentence Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017bd806a6be2ddbfd

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@mountiny
Copy link
Contributor

I do not have android device to reproduce this unfortuntely

@kbecciv
Copy link
Author

kbecciv commented Apr 24, 2024

Issue is still reproducible on build 1.4.65.3

rcg.mp4

@mountiny mountiny changed the title [$250] Android - Chat - User unable to select complete sentence [$500] Android - Chat - User unable to select complete sentence Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Upwork job price has been updated to $500

@KirtirajM
Copy link

I want to solve this issue but I am unable to run the project on my mac , because of I don't have MapBox token

Copy link

melvin-bot bot commented Apr 25, 2024

📣 @KirtirajM! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link

melvin-bot bot commented Apr 25, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@TheFinalPush
Copy link

Contributor details
Your Expensify account email: kirtiraj.malkhede@outlook.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017ac6dbe6c552ee4c

Copy link

melvin-bot bot commented Apr 25, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@mountiny
Copy link
Contributor

@Skalakid is going to investigate this one

I am going to demote the blocker label as there is no clear offending PR for this one and it looks like it might be device specific issue too. There is a workaround for the user to use the long press and copy to clipboard

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 25, 2024
@Skalakid
Copy link
Contributor

Hi, I'm Michał from Software-Mansion and I will investigate this issue

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@quinthar quinthar changed the title [$500] Android - Chat - User unable to select complete sentence HIGH: [UX Reliability] [$500] Android - Chat - User unable to select complete sentence Apr 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 27, 2024
@quinthar quinthar changed the title HIGH: [UX Reliability] [$500] Android - Chat - User unable to select complete sentence HIGH: [Live Markdown] [$500] Android - Chat - User unable to select complete sentence Apr 27, 2024
@Skalakid
Copy link
Contributor

Skalakid commented Apr 29, 2024

After investigation, I found that the problem with text selection on Android had a root cause in the react-native-live-markdown library. It was only reproducible after enabling the new architecture. I reported this bug and asked for help from our SWM team that worked on that. @j-piasecki came up with the fix in the library - PR and @WoLewicki prepared the PR that bumps the live markdown version in E/App

@hayata-suenaga
Copy link
Contributor

is the work being done in this PR going to fix this issue?

@melvin-bot melvin-bot bot added the Overdue label May 1, 2024
Copy link

melvin-bot bot commented May 2, 2024

@mountiny, @Skalakid, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Skalakid
Copy link
Contributor

Skalakid commented May 6, 2024

@hayata-suenaga The issue has been fixed inside the react-native-live-markdown library and this PR contained version bump inside it. However, I can see that the library version has been already updated on main, so the issue should be fixed for now

@melvin-bot melvin-bot bot removed the Overdue label May 6, 2024
@hayata-suenaga
Copy link
Contributor

@mountiny, it seems like we can close this issue 😄

@melvin-bot melvin-bot bot added the Overdue label May 8, 2024
@mountiny
Copy link
Contributor

mountiny commented May 8, 2024

@kavimuru @isagoico Could you please retest this issue on latest Android version?

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels May 8, 2024
@quinthar
Copy link
Contributor

quinthar commented May 9, 2024

@kavimuru @isagoico - Can you give an ETA on retesting on Android?

@isagoico
Copy link

isagoico commented May 9, 2024

Apologies that we missed this yesterday. Checking with the team as I don't have my Android charged up and will post the results shortly.

@isagoico
Copy link

isagoico commented May 9, 2024

Tester was unable to reproduce this on the latest version 1.4.72-1

screen-20240509-192511.mp4

@mountiny
Copy link
Contributor

Thank you, i will close then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

9 participants