Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-31] [HIGH] [VIP Travel] Add Workspace Address context - newDot #41119

Closed
twisterdotcom opened this issue Apr 26, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@twisterdotcom
Copy link
Contributor

twisterdotcom commented Apr 26, 2024

We added Workspace Address for Spotnana (because it is a required field for provisioning an Organization and it's member travellers and admins).

NewDot: (Mock)
image.

We did this here: #38381

We want to add some subtext, already agreed upon internally here: https://github.com/Expensify/Expensify/issues/390977

A Workspace Address is required to enable Expensify Travel. Please enter an address associated with your business.

@pecanoro how is this?

Se requiere una dirección para habilitar Expensify Travel. Por favor, introduce una dirección asociada con tu negocio.

image

Copy link

melvin-bot bot commented Apr 26, 2024

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@twisterdotcom
Copy link
Contributor Author

Why do we need Puneet here?

@twisterdotcom twisterdotcom changed the title [HIGH] [VIP Travel] Add Workspace Address context [HIGH] [VIP Travel] Add Workspace Address context - newDot Apr 26, 2024
@puneetlath
Copy link
Contributor

I think it auto-adds a BZ to NewFeature GH issues in the App repo.

@smelaa
Copy link
Contributor

smelaa commented Apr 29, 2024

Hi, my name is Aleksandra Smela, I am from Software Mansion and I would like to work on this issue.

@twisterdotcom
Copy link
Contributor Author

Perfect, thanks @smelaa!

@pecanoro
Copy link
Contributor

Se requiere una dirección para habilitar Expensify Travel. Por favor, introduce una dirección asociada con tu negocio.

@twisterdotcom
Copy link
Contributor Author

@smelaa just to make sure you saw that. I updated the OP too with it. Thanks @pecanoro!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 7, 2024
@marcochavezf
Copy link
Contributor

Assigning @ikevin127 as C+ reviewer

@twisterdotcom twisterdotcom added the Awaiting Payment Auto-added when associated PR is deployed to production label May 28, 2024
@twisterdotcom twisterdotcom changed the title [HIGH] [VIP Travel] Add Workspace Address context - newDot [HOLD for payment 2024-05-31] [HIGH] [VIP Travel] Add Workspace Address context - newDot May 28, 2024
@twisterdotcom
Copy link
Contributor Author

Payment Summary:

@ikevin127
Copy link
Contributor

ikevin127 commented May 31, 2024

@twisterdotcom Offer accepted, awaiting payment.

@twisterdotcom
Copy link
Contributor Author

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Development

No branches or pull requests

6 participants