Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasted content is placed at the beginning of the message and not where the cursor is positioned and undo (CTR+Z) is not working #4120

Closed
isagoico opened this issue Jul 16, 2021 · 6 comments · Fixed by #4131
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@isagoico
Copy link

isagoico commented Jul 16, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to e.cash and navigate to a conversation
  2. Send a message
  3. After the message has sent, copy it
  4. In the compose box, enter some text
  5. With the cursor at the end of the input, paste the message
  6. Press the shortcut for undo (CTRL+Z)

Expected Result:

Pasted content should be displayed were the cursor was positioned, in this case at the end of the message. CTRL+Z should undo the last action that was the pasted content.

Actual Result:

Pasted content is displayed at the start of the message and CRTL+Z does not remove the pasted content.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App ✔️
Mobile Web

Version Number: 1.0.79-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

KkUUmcOWPQ

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @alex-mechler https://expensify.slack.com/archives/C01GTK53T8Q/p1626366219328100

When pasting content from another message on Desktop, the pasted content is always placed at the beginning of the compose, regardless of where the cursor is. Reproduction steps in the thread

@MelvinBot
Copy link

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico isagoico changed the title Pasted content is placed at the beginning of the message and not where the cursor is positioned Pasted content is placed at the beginning of the message and not where the cursor is positioned and undo (CTR+Z) is not working Jul 16, 2021
@mountiny
Copy link
Contributor

This seems like it can be worked on by a contributor! Adding External label then.

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jul 16, 2021
@MelvinBot
Copy link

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mountiny
Copy link
Contributor

But I am going to keep myself assigned and look into to once I will have time if noone will make proposal to solve it before that.

@rdjuric
Copy link
Contributor

rdjuric commented Jul 16, 2021

@parasharrajat
Copy link
Member

Thanks, @rdjuric. I am looking at it already. There is one thing that is bothering me at ATM how ctrl+z will work. What is the best thing to do here? Should we really need to override this via keyboard event?

@mountiny mountiny added the Reviewing Has a PR in review label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants