[Awaiting Payment] [$250] [QBO] Open "Accounting" page can show "Hmm... it's not here"

[aldo-expensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Create Workspace
2. Go to "More Settings"
3. Make your connection extra slow using the dev tools
4. Enable "Accounting" for the first time
5. Quickly navigate to the new "Accounting" menu that appeared (before the request EnablePolicyConnections is resolved)

Expected Result:

If the data is not ready, we should see a skeleton loader on the Connections card in the Accounting page, not "Hmm... it's not here" page

Actual Result:

"Hmm... it's not here" page is shown briefly

Screen.Recording.2024-04-29.at.1.28.39.PM.mov

Workaround:

Wait for some time

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01270b3d16e231f2ad
• Upwork Job ID: 1785284479820603392
• Last Price Increase: 2024-05-07

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[aldo-expensify]

cc @hayata-suenaga @trjExpensify

[trjExpensify]

This can go external, right? I wonder if a skeleton loader is better than a spinner here. CC: @Expensify/design for thoughts before we move this on.

[aldo-expensify]

This can go external, right?

Very likely, I haven't investigated though. Maybe it is about optimistic data when we enable "Accounting"

[dubielzyk-expensify]

I don't feel super strongly if we do spinner or skeleton loader. I'll let @dannymcclain or @shawnborton decide.

Spinner:

Skeleton:

[shawnborton]

I like the idea of the skeleton personally!

[trjExpensify]

Samesies, I like the skelly!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01270b3d16e231f2ad

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[trjExpensify]

This can go external, right?

Very likely, I haven't investigated though. Maybe it is about optimistic data when we enable "Accounting"

Sounds good, I'll move it on for now!

[melvin-bot]

@johncschuster, @eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[narefyev91]

I will pick this one

[trjExpensify]

SOLD! 😂

[s77rt]

I'm not able to reproduce this. Is this still reproducible? I'm guessing this was caused by a bug in Onyx and it's now fixed. The optimistic data looks good to me.

[hayata-suenaga]

I'm not able to reproduce this. Is this still reproducible? I'm guessing this was caused by a bug in Onyx and it's now fixed. The optimistic data looks good to me.

nice! I also don't know why the optimistic data didn't have an effect before. In that case, do we still need @narefyev91's PR? We don't have a situation where the loading screen implemented in the PR is actually displayed, right?

[narefyev91]

@hayata-suenaga full page loading indicator will be shown - when we will be fetching possible connections. And with low connection user will see: 1) Card with default connections ex. Quickbooks online and Xero; 2) Full screen loading indicator; 3) again Card with fetched and default connections.
That's why the decision was made to not show full screen loading indicator - to prevent jumping content - but just show Connections card initially and skeleton during loading inside it.
My PR just introduce these changes

[s77rt]

@narefyev91 I'm not sure I see the problem, can you provide reproduction steps for that? As far as I can tell the PR seems only needed to switch from the full page loading indicator to the skeleton view

[narefyev91]

@narefyev91 I'm not sure I see the problem, can you provide reproduction steps for that? As far as I can tell the PR seems only needed to switch from the full page loading indicator to the skeleton view

Yeah - this is the only change needs to make - just move away from full page loading indicator and use skeleton during fetching available options for connections

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

Is this still open for something? 🤔

[hayata-suenaga]

@eVoloshchak, can you provide a summary of the latest on this issue? 🙇

[eVoloshchak]

The issue is resolved, not sure if there are any outstanding payments for @s77rt and @narefyev91

[melvin-bot]

❌ There was an error making the offer to @s77rt for the Contributor role. The BZ member will need to manually hire the contributor.

[trjExpensify]

Assigning @s77rt who's due payment for C+ review of the PR. @johncschuster can you action on that? Thanks!

[johncschuster]

Looks like the PR was deployed about two weeks ago, so this should be clear for payment! 🎉

[johncschuster]

Payment Summary:

Contributor+: @s77rt - $250 - paid via Upwork. Please accept the invite!

[s77rt]

@johncschuster Accepted! Thanks!

[johncschuster]

Payment has been issued! Thanks for your contributions!