Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Send invoice - Chat shows skeleton briefly after the invoice is created #41286

Closed
4 of 6 tasks
m-natarajan opened this issue Apr 30, 2024 · 19 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.68-0
Reproducible in staging?: Yes
Reproducible in production?: No (New Feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Send invoice.
  3. Enter amount and select participant.
  4. Create the invoice.

Expected Result:

Workspace chat will not show skeleton after the invoice is created.

Actual Result:

Workspace chat shows skeleton briefly after the invoice is created.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466123_1714441645430.bandicam_2024-04-30_09-44-33-566.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f373288cc7fa0358
  • Upwork Job ID: 1785187180184702976
  • Last Price Increase: 2024-05-07
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 30, 2024
@melvin-bot melvin-bot bot removed the Hourly KSv2 label Apr 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

We think this bug might be related to #wave-collect - Release 1

@m-natarajan
Copy link
Author

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@techievivek
Copy link
Contributor

Not a blocker, going to pass it to contributors.

@techievivek techievivek added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment labels Apr 30, 2024
@melvin-bot melvin-bot bot changed the title Send invoice - Chat shows skeleton briefly after the invoice is created [$250] Send invoice - Chat shows skeleton briefly after the invoice is created Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01f373288cc7fa0358

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@cristipaval
Copy link
Contributor

#vip-billpay related. @danielrvidal could you please help prioritize?

@danielrvidal
Copy link
Contributor

Seems like good clean up, but I would not say CRITICAL to launching for earnings. Marking it as medium. But yea, this would be great to have someone look into and clean up.

@cristipaval cristipaval added Weekly KSv2 and removed Daily KSv2 labels Apr 30, 2024
@cristipaval
Copy link
Contributor

Taking this one on me as a cleanup issue of my project. It should be fixed by my PR, which improves the Onyx updates sent after the SendInvoice command.

Copy link

melvin-bot bot commented May 7, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@abekkala abekkala added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels May 8, 2024
Copy link

melvin-bot bot commented May 8, 2024

Current assignee @alitoshmatov is eligible for the Internal assigner, not assigning anyone new.

@abekkala
Copy link
Contributor

abekkala commented May 8, 2024

removed the external and help wanted labels and added Internal as @cristipaval is taking this one

Copy link

melvin-bot bot commented May 14, 2024

@abekkala @cristipaval @alitoshmatov this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 16, 2024
@cristipaval
Copy link
Contributor

@alitoshmatov could you please verify if this is still reproducible when you have a minute?

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2024
@abekkala
Copy link
Contributor

@alitoshmatov just bumping the comment from Cristi for you!

@alitoshmatov
Copy link
Contributor

Not reproducible

Screen.Recording.2024-05-22.at.1.04.18.AM.mov

@cristipaval
Copy link
Contributor

Thanks a lot for retesting. I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

6 participants