[HOLD for payment 2024-05-22] Send invoice - Right caret disappears after editing and saving details several times

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: Yes
Reproducible in production?: No (New Feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice.
3. Enter amount and select a participant.
4. In the workspace chat, click on the preview.
5. Edit and save any row several times (scroll down the page to show the latest messages too).

Expected Result:

Right caret on each row will not disappear.

Actual Result:

Right caret on each row disappears after editing and saving the details several times.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6466064_1714436347964.right_caret.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

We think this bug might be related to #wave-collect - Release 1

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[MonilBhavsar]

Demoting from blocker as it is a non blocking minor UI issue for a new feature
Have asked PR authors if they want to take a look #40015 (comment)

[waterim]

Hello, Im Artem from Callstack and would like to help with this issue
cc @cristipaval

[cristipaval]

#vip-billpay related. @danielrvidal I'll make this one a MEDIUM. Feel free to update it as you think.

[danielrvidal]

I updated to low as I don't think this is a normal flow but I do think itis a good clean up.

[slafortune]

@waterim do you have an update?

[waterim]

Hello @slafortune @MonilBhavsar
I was OOO as we had public holidays in Poland
I'm continuing now!

[MonilBhavsar]

Thanks for update! 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Right caret disappears after editing and saving details several times #41768

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@waterim] Determine if we should create a regression test for this bug.
• [@waterim] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

@slafortune could you please add payment summary for review of #41768 (comment)

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Implement Send Invoice flow from Global Create #40015

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Implement Send Invoice flow from Global Create #40015 (comment)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. Yes

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

          1. Go to FAB > Send invoice.
          2. Enter amount and select a participant.
          3. In the workspace chat, click on the preview.
          4. Edit and save description/amount several times.
          5. Verify that the right caret on each row will not disappear.
   

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[MonilBhavsar]

Closing this as it was a regression and was fixed by original PR authors. Thanks all!

[JmillsExpensify]

I received a payment request for this PR, so I'm re-opening the issue to get a pament summary

[MonilBhavsar]

Ah, I see Rushat was not a review in the original PR.

Payment Summary: Pay $250 to Rushat for reviewing and testing PR

[JmillsExpensify]

$250 approved for @rushatgabhane