[HOLD for payment 2024-05-22] [$250] [QBO] Accounting - "Set up" button is top aligned in respective to "QBO" wording

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Go to Account settings > Workspaces > any workspace.
3. Go to Accounting.

Expected Result:

"Set up" button should be centered in respective to "QBO" wording (like the button with Xero).

Actual Result:

"Set up" button is top aligned in respective to "QBO" wording.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018936c575f9a5757c
• Upwork Job ID: 1785460764337295360
• Last Price Increase: 2024-05-01
• Automatic offers:
• neonbhai | Contributor | 0

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Set up" button is top aligned in respective to "QBO" wording

What is the root cause of that problem?

We are missing styles.justifyContentCenter on the set up button in ConnectToQuickbooksOnlineButton here:

App/src/components/ConnectToQuickbooksOnlineButton/index.native.tsx

Lines 42 to 52 in aee3a53

	<Button
	onPress={() => {
	if (shouldDisconnectIntegrationBeforeConnecting && integrationToDisconnect) {
	setIsDisconnectModalOpen(true);
	return;
	}
	setWebViewOpen(true);
	}}
	text={translate('workspace.accounting.setup')}
	small
	/>

What changes do you think we should make in order to solve the problem?

We will add:

import useThemeStyles from '@hooks/useThemeStyles';
...
const styles = useThemeStyles();

Then:

style={styles.justifyContentCenter}

here:

App/src/components/ConnectToQuickbooksOnlineButton/index.native.tsx

Lines 42 to 52 in aee3a53

	<Button
	onPress={() => {
	if (shouldDisconnectIntegrationBeforeConnecting && integrationToDisconnect) {
	setIsDisconnectModalOpen(true);
	return;
	}
	setWebViewOpen(true);
	}}
	text={translate('workspace.accounting.setup')}
	small
	/>

Result

This works perfectly

Before

After

[francoisl]

QBO is still behind a beta, not a blocker.

cc @hayata-suenaga @aldo-expensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018936c575f9a5757c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[neonbhai]

Raising PR soon!

[CortneyOfstad]

@neonbhai can you provide an update on the PR by end of day today? Thanks!

[neonbhai]

PR ready for review!

[CortneyOfstad]

Wasn't deployed the staging yet 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [QBO] - Fix: "Set up" button is top aligned in respective to "QBO" wording #41721

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @Santhosh-Sellavel requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

@Santhosh-Sellavel can you have the checklist above completed as soon as you can? This will help avoid any delays in payment — thank you!

[Santhosh-Sellavel]

@neonbhai Can you help me with where this got broken? This implementation PR and it was right, somewhere it got broken. Can you give a look?

[neonbhai]

@Santhosh-Sellavel hi, the style got deleted as part of this this commit in #40277

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: Xero authentication flow #40277
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: a880061#r1608696318
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A Should be caught while testing
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A Simple UI Polish
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

Payment Summary

@neonbhai — paid $250 via Upwork
@Santhosh-Sellavel — to be paid $250 via NewDot

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

$250 approved for @Santhosh-Sellavel