[HOLD for payment 2024-06-11] Send invoice - App crashes when sending invoice via link when there's no workspace

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User has no workspace.

1. Launch New Expensify app.
2. Copy send invoice link from web (https://staging.new.expensify.com/create/invoice/start/1/7783051691252045).
3. Paste the link on mobile app.
4. Click on the link.
5. Enter amount > Next.
6. Select participant.

Expected Result:

In Step 4, app should display not here link.

Actual Result:

In Step 4, user is able to proceed with send invoice flow.
After selecting participant in Step 6, app crashes. On web, it shows console error.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6466241_1714456420346.Screen_Recording_20240430_134316_One_UI_Home.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-bills.

[izarutskaya]

Production

Screen_Recording_20240430_115352_New.Expensify.mp4

[puneetlath]

I don't think this needs to be a deploy blocker, but @VickyStash do you want to look into it?

[VickyStash]

@puneetlath I'll take a look in a bit 👌 But I'm not sure if I can deal with it today (I'm going to be OOO 1st-8th of May)

[puneetlath]

Ok, I'm going to assign @cristipaval and @davidcardoza for now to let y'all figure out how to handle 😄

[danielrvidal]

This feels like a good cleanup issue so marking it as Low. I can't imagine a user actually pasting in the send invoice URL in a real flow. So I think if you have other urgent work, I'd prioritize that @VickyStash. But I agree we should clean this up.

[VickyStash]

NOTE: I'll be OOO 1-8th of May 🌴

[cristipaval]

I like the @tienifr solution to expand the AccessOrNotFoundWrapper and make it work for our current use case. I agree that it is cleaner and handles all pages of the flow automatically. Also, if we add a new page to the flow, it will be automatically handled, making the solution more scalable.

[melvin-bot]

This issue has not been updated in over 15 days. @davidcardoza, @cristipaval, @shubham1206agra, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Access control on IOU request #41730

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @tienifr requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @lschurr you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @shubham1206agra paid $250 via Upwork
• ROLE: @tienifr paid $250 via Upwork

BugZero Checklist (@lschurr)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/jobs/~01eb357df404f2d36d)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[lschurr]

@shubham1206agra @tienifr - please accept the offers sent today so that we can pay and close :)

[tienifr]

Thanks @lschurr, I accepted it

[shubham1206agra]

@lschurr Accepted

[lschurr]

All set!