[HOLD for payment 2024-06-11] [$250] Send invoice - (archived) is not appended to chat and Leave option is shown when WS is deleted

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to FAB > Send invoice.
4. Send an invoice to any user.
5. Delete the workspace in Step 2.
6. Go to the invoice workspace chat.
7. Click 3-dot menu (might have to revisit the chat for Leave option to show up).

Expected Result:

In Step 6, the invoice workspace chat should be appended with (archived) when the workspace is deleted.
In Step 7, there should not be a Leave option in the invoice workspace chat.

Actual Result:

In Step 6, the invoice workspace chat is not appended with (archived) when the workspace is deleted.
In Step 7, there is a Leave option in the invoice workspace chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6466262_1714459077080.20240430_143317.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01399b3e5a52c47027
• Upwork Job ID: 1785276283373862912
• Last Price Increase: 2024-05-10

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

Recording.2412.mp4

[lakchote]

This issue isn't critical/a blocker because of it's impact and the reproduction steps. It can be handled by external contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01399b3e5a52c47027

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

(archived) is not appended to the title of an archived invoice room. Leave option appears for an archived room.

What is the root cause of that problem?

We are overwriting formatted name for archived room here

App/src/libs/ReportUtils.ts

Lines 3118 to 3128 in e0c12a5

	if (isArchivedRoom(report)) {
	formattedName += ` (${Localize.translateLocal('common.archived')})`;
	}
	if (isSelfDM(report)) {
	formattedName = getDisplayNameForParticipant(currentUserAccountID, undefined, undefined, true);
	}
	if (isInvoiceRoom(report)) {
	formattedName = getInvoicesChatName(report);
	}

because isInvoiceRoom check happens later.
Leave appears for all archived rooms not just merchant rooms and might be expected behaviour.

What changes do you think we should make in order to solve the problem?

We move the archived room check below the isInvoiceRoom check.
If we want to remove Leave as well we can check for archived room at the beginning here and return false

App/src/libs/ReportUtils.ts

Line 5468 in e0c12a5

if (isInvoiceRoom(report)) {

What alternative solutions did you explore? (Optional)

[cristipaval]

Held on https://github.com/Expensify/Expensify/issues/388870

[cristipaval]

#vip-billpay related cc @danielrvidal

[danielrvidal]

This looks like good clean up! Going to mark as low though as we don't need it for the release. It will be good to clean it up though!

[cristipaval]

oh DANG, Thanks for reminding me, @c3024. Is this still reproducible since I removed the HOLD?

[c3024]

@cristipaval , yes, it is still reproducible.

[cristipaval]

I think @rezkiy37 is still appropriate for working on this, given that he worked on the original PRs that implemented the invoice rooms.

[rezkiy37]

Since I am an author of the original PR, I am considering the issue as a regression. I am preparing a PR, opening for review today.

[rezkiy37]

The PR has been opened.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix archived invoice room titles #42085

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests
• @rezkiy37 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

Not overdue. Payment date is tomorrow.

[lschurr]

Payment summary:

• Contributor+: $250 @mollfpr requires payment through NewDot Manual Requests
• Contributor: @rezkiy37 does not require payment (Contractor)

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to
ensure the same bug will not reach production again.

1. Create a workspace.
2. Go to the FAB > Send invoice.
3. Send an invoice to any user.
4. Delete the newly created workspace.
5. Go to the invoice room.
6. The invoice room title should be appended with (archived).
7. Click the 3-dot menu.
8. Verify that there is no Leave option shown
9. Click on the invoice report.
10. Verify that the (archived) label appears in the subtitle.
11. 👍 or 👎

[JmillsExpensify]

$250 approved for @mollfpr. Re-opening issue for regression test.

[lschurr]

Ah, missed that, thanks!

[lschurr]

Submitted request to add QA test. Closing :)