Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice - Room name displays the wrong name #41321

Closed
4 of 6 tasks
m-natarajan opened this issue Apr 30, 2024 · 10 comments
Closed
4 of 6 tasks

Invoice - Room name displays the wrong name #41321

m-natarajan opened this issue Apr 30, 2024 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.68-0
Reproducible in staging?: yes
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Create a workspace
  2. Click on 'FAB' > Send Invoice > Enter amount > Click 'Next'
  3. Select user > select workspace > click 'Send invoice'
  4. Click on report header > Settings > Room name

Expected Result:

Room name should display 'chat-report'

Actual Result:

Room name displays '#hat report'

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466526_1714479757162.Screen_Recording_2024-04-30_at_3.13.12_in_the_afternoon.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this bug might be related to #wave-collect - Release 1

@cristipaval
Copy link
Contributor

I'll take this one, it is #vip-billpay related

@cristipaval cristipaval assigned cristipaval and unassigned flodnv Apr 30, 2024
@cristipaval cristipaval added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Apr 30, 2024
@cristipaval
Copy link
Contributor

demoting as it is a minor UI thing

@cristipaval
Copy link
Contributor

#vip-billpay related. cc @danielrvidal

@danielrvidal
Copy link
Contributor

danielrvidal commented Apr 30, 2024

@cristipaval should we close this one in lieu of the below, which is going to remove the room name field in general?
[$250] Send invoice - Changing the room name in workspace invoice sends the report to skeleton view #41270

@cristipaval
Copy link
Contributor

you're right, we should close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

5 participants