Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send invoice - Merchant is not displayed in the invoice preview in the main chat for receiver #41323

Closed
6 tasks done
m-natarajan opened this issue Apr 30, 2024 · 11 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.68-0
Reproducible in staging?: Yes
Reproducible in production?: No (New Feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. [User A] Go to FAB > Send invoice.
  3. [User A] Create an invoice with merchant and send it to User B.
  4. [User A] Note that merchant is displayed in invoice preview in the main chat.
  5. [User B] Navigate to the invoice workspace chat.

Expected Result:

Merchant will be displayed in the invoice preview in the main chat for User B.

Actual Result:

Merchant is not displayed in the invoice preview in the main chat for User B.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466542_1714480744444.20240430_203537.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01522edd8c168d9599
  • Upwork Job ID: 1785603668502433792
  • Last Price Increase: 2024-05-01
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this bug might be related to #wave-collect - Release 1

@cristipaval
Copy link
Contributor

cristipaval commented Apr 30, 2024

#vip-billpay related. cc @danielrvidal

@cristipaval cristipaval added Daily KSv2 and removed Hourly KSv2 labels Apr 30, 2024
@cristipaval
Copy link
Contributor

demoting

@cristipaval cristipaval removed the DeployBlockerCash This issue or pull request should block deployment label Apr 30, 2024
@danielrvidal danielrvidal moved this from Medium to High in [#whatsnext] #billpay Apr 30, 2024
@danielrvidal danielrvidal moved this from High to Medium in [#whatsnext] #billpay Apr 30, 2024
@jliexpensify
Copy link
Contributor

@cristipaval this should be Internal right?

@cristipaval cristipaval added the Internal Requires API changes or must be handled by Expensify staff label May 1, 2024
Copy link

melvin-bot bot commented May 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01522edd8c168d9599

@cristipaval
Copy link
Contributor

yes, internal for now

Copy link

melvin-bot bot commented May 1, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ikevin127 (Internal)

@cristipaval cristipaval added the Reviewing Has a PR in review label May 2, 2024
@github-project-automation github-project-automation bot moved this from Medium to Done in [#whatsnext] #billpay May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

5 participants