Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet - "Debit card setup not allowed" error appears when adding a card #41601

Closed
2 of 6 tasks
lanitochka17 opened this issue May 3, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented May 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.70.0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
**If this was caught during regression testing, add the test name, ID and link from TestRail:**https://expensify.testrail.io/index.php?/tests/view/4538717&group_by=cases:section_id&group_order=asc&group_id=229064
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in with an expensifail account
  2. Navigate to Profile - Wallet - Add bank account - Debit card
  3. Add "4000056655665556" as the Debit card number and fill the rest with random data
  4. Tap on the "Save" button
  5. Fill the fields with random data
  6. Tap on the "Save & continue" button

Expected Result:

I should be able to add a card without errors

Actual Result:

"Debit card setup not allowed" error appears when adding a card. The card is actually added and visible if you navigate back to the Wallet tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6470083_1714743835498.AMTP0649.mp4

Bug6470083_1714743835478!IMG_2049

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label May 3, 2024
Copy link

melvin-bot bot commented May 3, 2024

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented May 3, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@francoisl
Copy link
Contributor

This error is coming from the backend, and the code doesn't seem to have changed in a while. According to the code here we don't support setting up wallets with debit cards on purpose, so it's surprising that this test would have ever passed. It's not even a new test too, it was added in April 2023(?)

@thienlnam
Copy link
Contributor

Sounds like this isn't a blocker then? We should actually change the error message here though

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 3, 2024
@francoisl
Copy link
Contributor

I'm not sure... Maybe it is?

Reproducible in production?: Unable to check

Curious why, is this a new flow that was just added on a PR that's on staging now?

Copy link

melvin-bot bot commented May 7, 2024

@thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam
Copy link
Contributor

Asked about this here https://expensify.slack.com/archives/C9YU7BX5M/p1714763098629059

Turns out this was probably happening on prod but wasn't tested there since it would require a real debit card

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants