[HOLD for payment 2024-06-11] [Xero] Provide access to Xero related screens only if the integration connected is Xero

[lakchote]

Problem

Right now, components that use <SelectionScreen> do not check if the current integration connected is Xero.

Solution

As discussed here, we'll need to add the corresponding checks and modify shouldBeBlocked in the components that use <SelectionScreen>, to make sure we can only access the related screens if we have the Xero integration connected.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ishpaul777 (Internal)

[mananjadhav]

@lakchote I can take this up for development.

[hungvu193]

I believe we should also update the logic of ConnectionLayout as well not only SelectionScreen

[mananjadhav]

I'll take care of both in all screens.

[mananjadhav]

I raised one of the last PRs on the Xero screen. Once I receive feedback on that I'll start working on this one.

[mananjadhav]

Waiting for this large PR to get merged #42043. Will start this tomorrow.

[lakchote]

@mananjadhav any update?

[mananjadhav]

I priotized other fixes in the last week. I'll raise the PR for this one by tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Wave collect] [Xero] Block Xero screens if Xero is not connected. #42619

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @MitchExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mananjadhav owed $250 via NewDot
• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ishpaul777]

No payment due to me

[mananjadhav]

@MitchExpensify There won't be any payout for this one. This is handled centrally as a flat fee.

[mananjadhav]

We're good to close this one out.