-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add focus-trap-react library #41877
Comments
Triggered auto assignment to @mountiny ( |
New Library Review
Once these questions are answered, start a thread in #engineering-chat, ping the
|
@jnowakow There seems to be only one person maintaining this and the library seems to be one file. Is there a specific reason to use this library instead of just creating our own lib function that could do the same given its not that complex code? |
For me the reason is that it's ready to use and doesn't introduce any security concerns. It's also tested as it's quite popular. So, I don't see a point in rewriting it as it would require us to spend time on the rewrite. We can make a mistake when rewriting. And then we need to maintain the lib. In summary I don't see reason why we would need to copy it instead of using ready package |
Shared here |
@jnowakow I believe we are good to go here with the PR, we got couple 👍 and no 👎 from deployers |
@jnowakow this is ready to move ahead |
Name of library: focus-trap-react
Details
No security concerns
2
91.8kb
Link to PR adding the library
The text was updated successfully, but these errors were encountered: