Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Held on 39520] IOU - Pressing on the space bar while date picker RHP is open scrolls the details page #41928

Closed
1 of 6 tasks
lanitochka17 opened this issue May 9, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented May 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.72-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Pre-conditions:

  • The screen size of your monitor/laptop should be small so that there is a scrollable space while in the expense details page
  1. Navigate to staging.new.expensify.com
  2. Create an expense and navigate to the expense details page
  3. Open the Date picker RHP
  4. Press on the space bar on your keyboard

Expected Result:

Nothing happens

Actual Result:

The app scrolls up the expense details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6475966_1715262571563.bandicam_2024-05-09_16-09-32-954.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 9, 2024
Copy link

melvin-bot bot commented May 9, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@bernhardoj
Copy link
Contributor

I believe it's gonna be fixed by the focus trap PR. There was an old issue similar to this before but closed.

cc: @roryabraham

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
Copy link

melvin-bot bot commented May 14, 2024

@anmurali Huh... This is 4 days overdue. Who can take care of this?

@anmurali anmurali changed the title IOU - Pressing on the space bar while date picker RHP is open scrolls the details page [Held on 39520] IOU - Pressing on the space bar while date picker RHP is open scrolls the details page May 14, 2024
@anmurali
Copy link

Let's test once that PR is shipped in that case.

@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
@anmurali anmurali added Weekly KSv2 Overdue and removed Daily KSv2 labels May 14, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
Copy link

melvin-bot bot commented May 23, 2024

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 23, 2024
@anmurali
Copy link

anmurali commented Jun 5, 2024

#39520 is still being worked on

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2024
@saracouto saracouto added Monthly KSv2 and removed Weekly KSv2 labels Jun 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2024
@anmurali
Copy link

There was a regression and that's being fixed, so still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
@anmurali
Copy link

Same status as ^^

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@anmurali
Copy link

Fixed.

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants