Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search v1] Tracked expenses show with _FAKE_ on the Search page #41985

Closed
6 tasks done
trjExpensify opened this issue May 10, 2024 · 15 comments
Closed
6 tasks done

[Search v1] Tracked expenses show with _FAKE_ on the Search page #41985

trjExpensify opened this issue May 10, 2024 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented May 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.72-1
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1715353965643159?thread_ts=1715336686.106629&cid=C036QM0SLJK

Action Performed:

  1. Go to global create > Track expense
  2. Track an expense to the selfDM
  3. Go to avatar > Troubleshoot > New search page
  4. Observe the tracked expense with the _Fake_ To/From fields in the table on the Search page

Expected Result:

The From: should be the account holder (i.e Tom James and the To: should be the name of the selfDM chat (i.e Tom James (You).

Actual Result:

FAKE to/from fields.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image image image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01784dd4287018110a
  • Upwork Job ID: 1788993640843829248
  • Last Price Increase: 2024-05-10
Issue OwnerCurrent Issue Owner: @luacmartins
@trjExpensify trjExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect May 10, 2024
@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01784dd4287018110a

Copy link

melvin-bot bot commented May 10, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@trjExpensify
Copy link
Contributor Author

@luacmartins is going to look at this later in the week.

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@trjExpensify trjExpensify moved this from Release 2: Summer 2024 (Aug) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 14, 2024
@luacmartins
Copy link
Contributor

Gonna work on this tonight!

@trjExpensify
Copy link
Contributor Author

Gonna work on this tonight!

Why did yah move this into Hot Picks? 🤔

@luacmartins luacmartins moved this from HOT PICKS to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 16, 2024
@luacmartins
Copy link
Contributor

Just wanted to check that you're paying attention to these 😉 Jk jk I moved it by mistake along with the other issues when looking for volunteers.

@luacmartins
Copy link
Contributor

Looking at this now

@trjExpensify
Copy link
Contributor Author

Just wanted to check that you're paying attention to these 😉 Jk jk I moved it by mistake along with the other issues when looking for volunteers.

Hahah.. 4D chess, huh? Just you wait... 😂

@luacmartins
Copy link
Contributor

PR in review.

@luacmartins luacmartins added the Reviewing Has a PR in review label May 16, 2024
Copy link

melvin-bot bot commented May 23, 2024

@trjExpensify, @luacmartins, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@trjExpensify
Copy link
Contributor Author

AuthPR deployed to prod. Is that it here or is there more to come?

@luacmartins
Copy link
Contributor

That was the only PR needed for the track case. @trjExpensify could you test again and see if the issue is fixed or there are other __FAKE__ edge cases?

@trjExpensify
Copy link
Contributor Author

Track is looking good!

image

@luacmartins
Copy link
Contributor

We can close this issue then since it's all internal and PR is deployed

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants