[HOLD for payment 2024-06-13] [$125] Fix inconsistency with task details view

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: #40858 (comment)

Action Performed:

1. Create a task
2. Click on the task details page

Expected Result:

The details view should match the report header view like these other report types

Actual Result:

Currently the task details page just shows the task title

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d9c0a9595a888d2c
• Upwork Job ID: 1791555314142978048
• Last Price Increase: 2024-05-24
• Automatic offers:
• GandalfGwaihir | Contributor | 102506848

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d9c0a9595a888d2c

[melvin-bot]

Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $125

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency in subtitle for task

What is the root cause of that problem?

We do not add subtitle if the report is a task:

App/src/pages/ReportDetailsPage.tsx

Line 312 in e8ae3c5

{!isEmptyObject(parentNavigationSubtitleData) && (isMoneyRequestReport || isInvoiceReport || isMoneyRequest) && (

What changes do you think we should make in order to solve the problem?

Add a extra or check || as ReportUtils.isTaskReport(report), or create a separate variable isTaskReport.

So the updated condition will now be:

{!isEmptyObject(parentNavigationSubtitleData) && (isMoneyRequestReport || isInvoiceReport || isMoneyRequest || ReportUtils.isTaskReport(report)) && (

We can consolidate the ReportUtils.isTaskReport(report) function by assigning this value to a variable isTaskReport.

Result Screenshot

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The incorrect number of tags is shown, "3 selected" is shown instead of "2 selected"

What is the root cause of that problem?

For the header view, we always show the parent subtitle if parentNavigationSubtitleData isn't not empty

App/src/pages/home/HeaderView.tsx

Line 283 in e8ae3c5

{!isEmptyObject(parentNavigationSubtitleData) && (

App/src/components/AvatarWithDisplayName.tsx

Line 140 in e8ae3c5

{Object.keys(parentNavigationSubtitleData).length > 0 && (

But in ReportDetailPage, we only show this for some specials report

App/src/pages/ReportDetailsPage.tsx

Line 312 in e8ae3c5

{!isEmptyObject(parentNavigationSubtitleData) && (isMoneyRequestReport || isInvoiceReport || isMoneyRequest) && (

That is an inconsistency

What changes do you think we should make in order to solve the problem?

To consistent with the header view, we should always show the parent subtitle here by removing the check for special report

{!isEmptyObject(parentNavigationSubtitleData) && (
    <ParentNavigationSubtitle
        parentNavigationSubtitleData={parentNavigationSubtitleData}
        parentReportID={report?.parentReportID}
        parentReportActionID={report?.parentReportActionID}
        pressableStyles={[styles.mt1, styles.mw100]}
    />
)}

App/src/pages/ReportDetailsPage.tsx

Line 312 in e8ae3c5

{!isEmptyObject(parentNavigationSubtitleData) && (isMoneyRequestReport || isInvoiceReport || isMoneyRequest) && (

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

Great! @GandalfGwaihir could you please share when you can have a PR up?

[allgandalf]

Was AFK, got back to keyboard just now, let me quickly come up with a PR ASAP! working now

[allgandalf]

PR was merged, waiting to be deployed to staging 👍

[joekaufmanexpensify]

Great. TY!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix]: Inconsistency with task subtitle view with other report types #42791

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws / @allgandalf] The PR that introduced the bug has been identified. Link to the PR: We haven't enabled this behaviour for task reports since the inception of the details page so I don't think we can pin this on any PR.
• [@Ollyws / @allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@Ollyws / @allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@Ollyws / @allgandalf] Determine if we should create a regression test for this bug.
• [@Ollyws / @allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

@Ollyws offer sent for $125. Also, could you please complete BZ so we can prep to issue payment?

[joekaufmanexpensify]

@Ollyws Ah, I see you get paid via NewDot now, so withdrew the upwork offer.

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

We haven't enabled this behaviour for task reports since the inception of the details page so I don't think we can pin this on any PR.

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes.

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Create a task
2. Click on the task details page
3. Verify that subtitle is visible for tasks details page

Do we agree 👍 or 👎

[Ollyws]

Requested in ND.

[joekaufmanexpensify]

TY! This is a pretty minor visual bug, so IDT we need a regression test to be done every time here. So noted this above.

[joekaufmanexpensify]

All set to issue payment. We need to pay:

• @allgandalf - $125 for PR via Upwork.
• @Ollyws - $125 for C+ via NewDot.

[joekaufmanexpensify]

@allgandalf $125 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set. Thanks everyone!

[JmillsExpensify]

$125 approved for @Ollyws