Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-24] [Payment card / Subscription] [HOLD all] Rollout feature: replace Subscriptions menu item #42473

Closed
amyevans opened this issue May 22, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@amyevans
Copy link
Contributor

The Subscriptions menu item in the LHN of settings currently links out to OldDot.

Once the Payment card and subscription management in NewDot design doc engineering work is complete, we need to update the menu item to link to the new NewDot route instead of OldDot.

@amyevans amyevans self-assigned this May 22, 2024
@amyevans amyevans moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 22, 2024
@melvin-bot melvin-bot bot added the Overdue label May 30, 2024
@amyevans
Copy link
Contributor Author

Not ready to launch yet

@melvin-bot melvin-bot bot removed the Overdue label May 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 10, 2024
@amyevans amyevans assigned blimpich and unassigned amyevans Jun 10, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

@JKobrynski
Copy link
Contributor

JKobrynski commented Jun 14, 2024

I created a related section in the doc! Let me know if you'd like me to change/add anything

CC: @amyevans

@amyevans
Copy link
Contributor Author

Nice, LGTM!

@trjExpensify trjExpensify moved this from Release 1.5: XeroCon 2024 (June 12th) to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jul 8, 2024
Copy link

melvin-bot bot commented Jul 8, 2024

This issue has not been updated in over 15 days. @blimpich, @JKobrynski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Overdue labels Jul 8, 2024
@blimpich blimpich added Weekly KSv2 and removed Monthly KSv2 labels Jul 8, 2024
@blimpich
Copy link
Contributor

blimpich commented Jul 8, 2024

@JKobrynski could you put up a PR for this? We're not quite ready but there's no reason to not have the PR ready to go when we finally do want it to be launched.

@trjExpensify
Copy link
Contributor

I think we're only waiting on a prod deploy for the GBP PR from Friday to hit, looking at the latest deploy checklist on staging. I'd say let's put this on Daily priority at this point, we should aim to get it up and merged tomorrow. 👍

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 10, 2024
@rayane-djouah
Copy link
Contributor

@trjExpensify - could you please assign me here and give me access to the design doc (I requested access)? Thanks

@blimpich
Copy link
Contributor

@rayane-djouah shared it with the email you have on your slack profile rayanetech11@gmail.com 👍

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] [HOLD all] Rollout feature: replace Subscriptions menu item [HOLD for payment 2024-07-24] [Payment card / Subscription] [HOLD all] Rollout feature: replace Subscriptions menu item Jul 17, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 23, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@rayane-djouah
Copy link
Contributor

rayane-djouah commented Jul 24, 2024

Please assign me here for PR #45089 review payment and add bug label. Thanks!

@trjExpensify
Copy link
Contributor

Payment summary as follows:

Offer sent!

@rayane-djouah
Copy link
Contributor

Offer accepted

@trjExpensify
Copy link
Contributor

Paid, closing!

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants