Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tax - Tax amount is not updated when changing Tax rate #42682

Closed
2 of 6 tasks
izarutskaya opened this issue May 28, 2024 · 9 comments
Closed
2 of 6 tasks

Tax - Tax amount is not updated when changing Tax rate #42682

izarutskaya opened this issue May 28, 2024 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.76-3
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #40240
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: Tax should be enabled

  1. Navigate to a workspace chat
  2. Click '+' icon > Split expense > Enter amount > Select a tax rate
  3. Change the previously selected tax rate with a new rate

Expected Result:

Tax amount should be updated with the new tax rate

Actual Result:

Previously calculated tax rate is persisting

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6493697_1716880004016.Screen_Recording_2024-05-28_at_9.46.42_in_the_morning.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 28, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@izarutskaya
Copy link
Author

Production

Recording.2479.mp4

@Julesssss
Copy link
Contributor

Hey @izarutskaya. We reverted the PR this is related to.

@Julesssss Julesssss added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 28, 2024
@Julesssss
Copy link
Contributor

@MonilBhavsar I think we can just close this. But c=please could you confirm, I'm getting a bit confused with the linked issue and revert 😄

@MonilBhavsar
Copy link
Contributor

Yes, we can remove the labels and close this. I'll address this in a followup PR

@MonilBhavsar MonilBhavsar removed the DeployBlocker Indicates it should block deploying the API label May 28, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants