Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent lastMessageText to show "What would you like to do with this expense?" when there are no tracked expenses #42727

Closed
thienlnam opened this issue May 28, 2024 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@thienlnam
Copy link
Contributor

#41668 (comment)

When there are no more tracked expenses, the BE responds with lastMessageText of "What would you like to do with this expense?"

@thienlnam thienlnam added Monthly KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels May 28, 2024
@bfitzexpensify
Copy link
Contributor

@thienlnam what priority should this be? Looks like melv wants it to be daily, but you added monthly when opening...this seems like a pretty small deal, so I guess the latter?

@thienlnam
Copy link
Contributor Author

Yes please, this is low impact so either weekly or monthly

@bfitzexpensify
Copy link
Contributor

No update here.

@melvin-bot melvin-bot bot removed the Overdue label Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

@bfitzexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2024
@bfitzexpensify bfitzexpensify added Monthly KSv2 and removed Weekly KSv2 labels Jun 21, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2024
@bfitzexpensify
Copy link
Contributor

Low value, moving to monthly

@melvin-bot melvin-bot bot added the Overdue label Jul 22, 2024
@bfitzexpensify
Copy link
Contributor

Still not a priority

@melvin-bot melvin-bot bot removed the Overdue label Jul 23, 2024
@thienlnam
Copy link
Contributor Author

I think we can close this now that vip-vsb is paused. This doesn't really impact functionality or anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants