Inconsistent Distance Update When Editing Waypoints in Self DM and Workspace chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.76-0
Reproducible in staging?: y
Reproducible in production?: no, new feature for self DM
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Reproducible in gmail.com account
1, Go to Self DM > Plus Sign.
2, Track Expense > Select Distance > Select Start and End Points.
3, Go to Track Expense Detail > Edit Waypoint. Notice the distance live updates without clicking save, but it doesn't save when you go back.
4,Go to Workspace Chat > Plus Sign > Distance > Select Start and End Points.
5, Complete the flow > Edit the Waypoint. Notice the distance does not live update.

Expected Result:

When editing waypoints while tracking expenses in Self DM, the distance should update only when clicking save, consistent with the Workspace chat behavior.

Actual Result:

In Self DM, editing the distance live updates without clicking save, but the change isn't saved. In Workspace chat, the distance updates only after clicking save, causing inconsistency.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495062_1716984680955.Screen_Recording_2024-05-29_at_5.06.296_AM.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[luacmartins]

I'm not sure if the API response is incorrect or we're not processing the value properly in the frontend, since the API seems to return the value in meters, not km and we're just displaying that as km

[luacmartins]

I don't see any recent API changes touching this flow in the latest checklist so I'll remove the DeployBlocker label since it doesn't seem to be an API related blocker.

[amyevans]

Hmm I am not able to reproduce this bug on main or on staging, the behavior between the self DM and workspace chat is consistent (in both cases the distance live updates immediately, but it reverts to the prior value - not saving - if you exit out without saving).

Granted there is some weirdness going on with the units not matching between the "live update" version and the "saved" version as Carlos mentioned, but I don't think that's the point of this bug report.

The ability to edit distance for tracked expenses is new - introduced in #41633, cc @neil-marcellini in case you have any input, but a.) I don't think this needs to block deploy and b.) I can't reproduce so perhaps we can end up closing. @stephanieelliott could you give it a try?

[amyevans]

Vids for reference -

Workspace chat

workspace-chat.mov

DM chat

dm-chat.mov

[kavimuru]

Issue fixed in the version 1.4.77-3

Screen.Recording.2024-05-29.at.1.35.23.PM.mp4

[amyevans]

Thanks, closing!