[HOLD for payment 2024-06-20] [$250] Chat - Unable to open chat if going back from not found page after using send invoice link

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.78-2
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #41730
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the app and log in with an account that does not have a workspace
2. Paste the send invoice link https://staging.new.expensify.com/create/invoice/start/1/7783051691252045
   in any chat
3. Open the link
4. Tap the back icon
5. Open the chat where the link was shared

Expected Result:

The chat is opened.

Actual Result:

Unable to open the chat, it is not responding to a tap. It seems like user should be navigated to the chat in the first place instead of the LHN when going back from the not found page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6496964_1717122415517.video_2024-05-30_22-25-47.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019eaddaf6970628b2
• Upwork Job ID: 1796604996438876160
• Last Price Increase: 2024-05-31

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

RPReplay_Final1717130534.MP4

[cristipaval]

Removed the deploy blocker as per this plan. Let's assign @tienifr to fix and @shubham1206agra for the c+ review, since they are the authors of the original PR 🙏

[tienifr]

Taking a look.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019eaddaf6970628b2

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[kpadmanabhan]

@izarutskaya : i see that after multiple taps (randomly) the chat opens up and shows the page not found view. do you see the same behaviour? looking into the issue.

[kpadmanabhan]

Removed the deploy blocker as per this plan. Let's assign @tienifr to fix and @shubham1206agra for the c+ review, since they are the authors of the original PR 🙏

@tienifr / @cristipaval : can you please point me to the original PR here? Thank you.
Is it #41730?

[kpadmanabhan]

Removed the deploy blocker as per this plan. Let's assign @tienifr to fix and @shubham1206agra for the c+ review, since they are the authors of the original PR 🙏

@cristipaval : Is this already assigned to @tienifr as a regression issue? HelpWanted was misleading in this case without melvin-bot assigning this to @tienifr . I will await your confirmation before further investigation.

[tienifr]

I opened PR above ^

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: go back in AccessOrNotFoundWrapper #42976

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @tienifr requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)
• ROLE: @tienifr paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1796604996438876160/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[isabelastisser]

@shubham1206agra, please complete the BZ list above. Thanks!

[isabelastisser]

ROLE: c+ @shubham1206agra paid $250via Upwork
ROLE: Contributor @tienifr paid $250 via Upwork

@tienifr, can you please share your Upwork profile link?

@shubham1206agra I sent you an offer.

[tienifr]

@isabelastisser I'm working with Dylan to enable myself to receive payments via NewDot.

Could we hold paying me until after then, so it can be paid via NewDot?

Thanks!

[shubham1206agra]

@isabelastisser Sorry, but this issue was a regression and does not require any payment and checklist.

[tienifr]

Oh yes completely missed this. This is a regression.

[isabelastisser]

Thanks for the heads up! I will cancel @shubham1206agra offer in Upwork now.

Closing.