[HOLD for payment 2024-07-10] [$500] [One expense reports] The expense details are shown at the top, and then a report preview in the comments

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.78-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717176771231389

Action Performed:

1. Have a HT account as admin
2. Create a policy with some violation (category required) and leave the submission frequency as instantly
3. Invite a member A
4. As a member A create a report with only one expense
5. Log in as HT admin
6. Open the report

Expected Result:

Expense report preview should not appear in the expense details page

Actual Result:

Expense details showing at the top, and then a report preview of the same in the comments

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.159.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016087f922551bb586
• Upwork Job ID: 1798510897494771226
• Last Price Increase: 2024-06-18
• Automatic offers:
• wildan-m | Contributor | 102862232

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

I'm struggling to reproduce this myself, but given that Jason runs into it a lot and QA have reproduced. I'm going to move it forward.

Sounds like a perfect storm of HT account and slow internet connection are in play.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016087f922551bb586

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[marcus-cook]

I do have a feeling this has something to do with the JS. I would need access to recreate the issue and inspect elements on said page to really dial in exactly what is going on. Inspecting your main page, This is the only possible thing I could think of.

[melvin-bot]

📣 @marcuscook2169! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

@Pujan92, @trjExpensify Eep! 4 days overdue now. Issues have feelings too...

[trjExpensify]

I do have a feeling this has something to do with the JS. I would need access to recreate the issue and inspect elements on said page to really dial in exactly what is going on. Inspecting your main page, This is the only possible thing I could think of.

Any luck @marcuscook2169?

[melvin-bot]

Upwork job price has been updated to $500

[trjExpensify]

Still awaiting proposals.

[melvin-bot]

@Pujan92, @trjExpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@Pujan92, @trjExpensify 10 days overdue. Is anyone even seeing these? Hello?

[trjExpensify]

Still awaiting proposals. @Pujan92 don't suppose you fancy just taking this issue if we don't get any bites?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@Pujan92 @trjExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Pujan92]

I will try to reproduce the issue.

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[wildan-m]

@deetergp Any other feedback before we move on to the next step?

[deetergp]

Okay, let's go with @wildan-m's alternative solution.

[melvin-bot]

📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[wildan-m]

@Pujan92 The PR is ready for review. link

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix a report preview in the comments of one expense report. #44366

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @wildan-m requires payment automatic offer (Contributor)
• @Pujan92 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
• [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Pujan92] Determine if we should create a regression test for this bug.
• [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 checklist time!

[Pujan92]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: Add One Transaction Report View #36934
• [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/36934/files#r1672831481
• [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@Pujan92] Determine if we should create a regression test for this bug. Yes
• [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Create a collect policy
2. Invite a member A
3. Login as a member A and submit an expense within that policy
4. Log in as admin
5. Open that report
6. Verify that the IOU preview does not appear on that one expense report

[JmillsExpensify]

Ready to pay this once I get a payment summary.

[trjExpensify]

Thanks, Pujan! Payment summary as follows:

• $500 to @Pujan92 for the C+ review (go ahead and request)
• $500 to @wildan-m for the fix (paid!)

Closing!

[JmillsExpensify]

$500 approved for @Pujan92