[HOLD for payment 2024-08-07] [QBO Export] Implement offline pattern B for manual report exports

[arosiclair]

• HELD on [HOLD for payment 2024-07-25] [QBO Export] [$250] Implement manual report exports #44022

Part of QBO Export and Error Handling in NewDot

Doc section: https://docs.google.com/document/d/1aQl-AK_F6IqszWYG2aEllTsD5x3h4b8Zu0XEG0LuQ08/edit#heading=h.xw0s9oqvo44s
Project: https://github.com/orgs/Expensify/projects/129

Feature Description

During review for the detailed design, we decided we should support offline pattern B when manually exporting reports here. To implement that we need to

• Create an optimistic EXPORTINTEGRATION action in our Report.exportToIntegration and Report.markAsManuallyExported actions
  • The text should say started exporting this report to {integration}...
• Pass the optimisticReportActionID to both Report_Export and MarkAsExported APIs
• Use the ID to create the action in Auth
  • Auth will queue updates for the report action with the final text: exported this report to {integration}. [View out-of-pocket expenses].
• On failure
  • create the INTEGRATIONSMESSAGE action with the error message like normal (using a different ID)
  • delete the optimistic action on the frontend using failureData

Manual Test Steps

Sucessful offline export

1. Submit an expense report
2. Log in as the workspace admin
3. Approve the report
4. Go offline
5. 3-dot menu > Export > Quickbooks Online
6. Verify a semi-transparent started exporting this report to QuickBooks Online... message shows
7. Go online
8. Verify the action becomes fully opaque
9. Wait a few seconds
10. Verify the action updates to exported this report to QuickBooks Online. [View out-of-pocket expenses].

Failed offline export

Prerequisites

• Add a chart of account (category) to QBO that you can delete later

Steps

1. Create a report with an expense
2. Categorize the expense using the new QBO category
3. Submit it
4. Log in as the workspace admin and approve the report
5. Log into QBO and deactivate the chart of account for the category (Menu > Transactions > Chart of accounts > {account} menu > Make inactive)
6. Go offline in NewDot
7. Export the report to QBO (3-dot menu > Export > Quickbooks Online)
8. Verify a semi-transparent started exporting this report to QuickBooks Online... message shows
9. Go online
10. Verify the action becomes fully opaque
11. Wait a few seconds
12. Verify a report export error message is added the report

Automated Tests

• Verify optimisticData for the INTEGRATIONSMESSAGE is merged for both Report.exportToIntegration and Report.markAsManuallyExported actions
• Verify failureData removes the action

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[arosiclair]

cc @trjExpensify @lakchote @sakluger

[trjExpensify]

Sounds good, moved it into the release. 👍

[dylanexpensify]

Held!

[arosiclair]

Pointed the hold to #44022

[trjExpensify]

^^ updated the title to reflect that.

[dylanexpensify]

held

[kosmydel]

Hey, I'm from SWM and I would like to work on this issue :)

[trjExpensify]

Assigned you! Going to remove the Reviewing label as there isn't a PR for this yet right?

[kosmydel]

Assigned you! Going to remove the Reviewing label as there isn't a PR for this yet right?

Yep, we don’t have a PR for this yet.

[dylanexpensify]

Held

[dylanexpensify]

Still holding

[arosiclair]

Posted these PRs to support optimisticReportActionID:

• https://github.com/Expensify/Auth/pull/11663
• https://github.com/Expensify/Integration-Server/pull/7998
• https://github.com/Expensify/Web-Expensify/pull/42762

Should be able to get those deployed next week.

[dylanexpensify]

@arosiclair looks like 44022 is now in regression period - we good to take this off hold?

[arosiclair]

https://github.com/Expensify/Web-Expensify/pull/42762 still needs to get reviewed and merged and then we can finalize and merge #44733

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [QBO Export] Implement offline pattern B for manual report exports #44733

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @kosmydel does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[dylanexpensify]

Payment coming up!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• Contributor: @kosmydel is from an agency-contributor and not due payment

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[dylanexpensify]

Payment summary:

• Contributor: @kosmydel
• Contributor+: @hungvu193 $250

Please apply/request!

[JmillsExpensify]

$250 approved for @hungvu193