Profile - 2 options instead of 4 to pick in Troubleshoot > New search page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.79-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - internal Team

Issue found when executing PR #42184

Action Performed:

1. Go to Search Page, Profile > Troubleshoot > New search page

Expected Result:

There should be 4 options to pick

Actual Result:

There are 2 options to pick instead of 4. (Drafts and Finished are missing)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1871.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

2 options instead of 4 to pick in New search page

What is the root cause of that problem?

We are not adding drafts and finshed items here

App/src/pages/Search/SearchFilters.tsx

Line 34 in cb692c5

const filterItems: SearchMenuFilterItem[] = [

What changes do you think we should make in order to solve the problem?

We can add it like this here

    {
            title: translate('common.drafts'),
            query: CONST.TAB_SEARCH.DRAFTS,
            icon: Expensicons.Pencil,
            route: ROUTES.SEARCH.getRoute(CONST.TAB_SEARCH.DRAFTS),
        },
        {
            title: translate('common.finished'),
            query: CONST.TAB_SEARCH.FINISHED,
            icon: Expensicons.CheckCircle,
            route: ROUTES.SEARCH.getRoute(CONST.TAB_SEARCH.FINISHED),
        },

What alternative solutions did you explore? (Optional)

[Nodebrute]

@stitesExpensify Actually, we have temporarily disabled these options in this PR #43016

[neil-marcellini]

Thanks @Nodebrute, sounds like a non-issue so I'm closing it.