-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Log out - URL in sign in page is ../settings/troubleshoot after logging out #43057
Comments
Triggered auto assignment to @anmurali ( |
Triggered auto assignment to @tgolen ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsb |
Job added to Upwork: https://www.upwork.com/jobs/~0100e267e9dc04f517 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
I am removing the deploy blocker label since this is an edge case flow. I'm also marking it as |
Hi, I would like to work on this issue. |
📣 @gorvk! 📣
|
Reverting #42465 solves the issue for me. |
Contributor details |
@bernhardoj on reverting, will it not reopen the app crashing issue related #42465 PR ? |
Can u guys reproduce this on latest main? I couldn't reproduce it. |
I was also confused at first, and after debugging it is reproducible on staging.new.expensify.com |
@bernhardoj would u please provide video evidence before and after reverting #42465? |
The video is not exactly the same as in OP as it would be long to log out and log in twice, but you can see the URL path stays but is fixed after removing the patched code. Screen.Recording.2024-06-05.at.18.26.54.mov |
i am able to reproduce and reverting #42465 solves this, i think we need to modify regex to keep the trailing single updated Regex- Screen.Recording.2024-06-05.at.4.19.36.PM.mov |
Since the offending PR is still in the regression period @dominictb and @ishpaul777 handle this. |
alright, I'll wait for assignment before raising the PR cc @ishpaul777 |
@dominictb just to confirm are you able to reproduce and will you use this solution #43057 (comment)? |
@ishpaul777 yes 👍 |
🎀 👀 🎀 |
Current assignee @tgolen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Handled by @ishpaul777 and @dominictb as a regression |
we are good to close this one! No payment requires |
This issue has not been updated in over 15 days. @tgolen, @anmurali, @dominictb eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.79-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
URL in sign in page should be staging.new.expensify.com
Actual Result:
URL in sign in page is https://staging.new.expensify.com/settings/troubleshoot
after logging out.
The URL could be report URL other than https://staging.new.expensify.com/settings/troubleshoot
after logging out.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6501931_1717526574343.bandicam_2024-06-05_02-40-43-249.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @getushaThe text was updated successfully, but these errors were encountered: