[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Expense - "Receipt" label does not appear above receipt placeholder for p2p expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.79-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4574596
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense without receipt.
4. Go to transaction thread.
5. Note that "Receipt" label appears above receipt placeholder.
6. Submit an expense to any user.
7. Go to transaction thread.

Expected Result:

"Receipt" label will appear above receipt placeholder for p2p expense.

Actual Result:

"Receipt" label does not appear above receipt placeholder for p2p expense.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6502117_1717537256719.bandicam_2024-06-05_05-35-33-935.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ed4993b4406f58d2
• Upwork Job ID: 1798815121621554421
• Last Price Increase: 2024-06-06
• Automatic offers:
• getusha | Reviewer | 102644040
• neonbhai | Contributor | 102644041

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Receipt" label does not appear above receipt placeholder for p2p expense

What is the root cause of that problem?

We check for a paid group policy when showing receipt header

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 333 in 594ae48

const shouldShowReceiptHeader = isReceiptAllowed && (shouldShowReceiptEmptyState || shouldShowMapOrReceipt) && canUseViolations && ReportUtils.isPaidGroupPolicy(report);

What changes do you think we should make in order to solve the problem?

We should remove the paid group policy check here

const shouldShowReceiptHeader = isReceiptAllowed && (shouldShowReceiptEmptyState || shouldShowMapOrReceipt) && canUseViolations;

[luacmartins]

I don't think we need to block the deploy on this and it seems to be a regression from #41489. @Krishna2323 @sobitneupane could you please take a look?

[Krishna2323]

I believe we have decided to hide header and receipt notice violations for unpaid policy groups.

cc: @cead22 @sobitneupane

[sobitneupane]

Receipt Header was added for Notice Violations which is present only in paid policy. So, it is not being displayed for p2p expenses. @cead22 Can you please confirm the expected behavior here? Would we want to show receipt header for all the cases where either Receipt or Receipt Place Holder is present?

[cead22]

I think it makes sense to show the receipt header in all cases, since all the other fields have headers as well. What do you think @JmillsExpensify ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ed4993b4406f58d2

[getusha]

@neonbhai any updates?

[neonbhai]

PR is ready for review!

[CortneyOfstad]

PR is still being reviewed!

[CortneyOfstad]

PR deployed to staging 4 days ago 🎉

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: "Receipt" label does not appear above receipt placeholder for p2p expense #43405

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

@getusha can you please complete the checklist above before beginning of next week, so there is no delay in payment? Thanks!

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR: #41635
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #41635 (comment)
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. No, this bug isn't impactful enough to create a regression test
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a

[CortneyOfstad]

@getusha looks like we're still waiting for you to accept the payment in Upwork. Please let me know once you accept and I can get that paid ASAP. Thank you!

[CortneyOfstad]

Bump @getusha ^^^

I am heading OoO until Tuesday (July 9th) so I would like to get this paid as soon as possible without any further delay. Thanks!

[getusha]

Accepted, thanks @CortneyOfstad

[luacmartins]

@CortneyOfstad seems like the offer was accepted, can we close this issue now?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: "Receipt" label does not appear above receipt placeholder for p2p expense #43405

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @neonbhai requires payment automatic offer (Contributor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

Payment Summary

@getusha — paid $125 via Upwork
@neonbhai — paid $125 via Upwork