-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send invoice - Incomplete options on payment button when sending an invoice #43145
Comments
Triggered auto assignment to @AndrewGable ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
TLDR: We need to figure out if the offending PR actually missed something functionality-wise, or it's just a design-related misunderstanding. Posted #41859 (comment) in offending PR because we need to actually figure out whether the PR's changes are the actual expected result or this issue's expected result is what we want, since the PR's changes were approved by the design team. |
Seems like a daily bug, not a deploy blocker. We should fix but don't think we need to block deploy on this. Assigning the relevant members |
As I mentioned in this comment it's an expected result to have only |
Given this information, I think it's safe to say that we can close this out as NAB nor a regression. @cristipaval Most likely you have even more context on this new UI / functionality and would be able confirm on this. |
yes, this is expected for now. An upcoming PR will add one more option |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.79-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #41859
Action Performed:
Expected Result:
Verify that correct settlement button appears in preview and inside of the report header:
Actual Result:
The menu of the button presents only the option "Pay $x as an individual" and the options like the desing are not displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6502141_1717539218996.Video_de_WhatsApp_2024-06-04_a_las_17.04.00_73bb9aa4.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: