Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send invoice - Incomplete options on payment button when sending an invoice #43145

Closed
2 of 6 tasks
lanitochka17 opened this issue Jun 5, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.79-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41859

Action Performed:

  1. Open the app in mWeb
  2. Go to FAB
  3. Select "Send invoice"
  4. Send Invoice
  5. Go to user who needs to pay this invoice

Expected Result:

Verify that correct settlement button appears in preview and inside of the report header:

  • Personal Card or Bank account
  • Business Card or Bank account
  • Forward to someone else

Actual Result:

The menu of the button presents only the option "Pay $x as an individual" and the options like the desing are not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6502141_1717539218996.Video_de_WhatsApp_2024-06-04_a_las_17.04.00_73bb9aa4.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 5, 2024
Copy link

melvin-bot bot commented Jun 5, 2024

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@ikevin127
Copy link
Contributor

TLDR: We need to figure out if the offending PR actually missed something functionality-wise, or it's just a design-related misunderstanding.

Posted #41859 (comment) in offending PR because we need to actually figure out whether the PR's changes are the actual expected result or this issue's expected result is what we want, since the PR's changes were approved by the design team.

@AndrewGable AndrewGable removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jun 5, 2024
@AndrewGable AndrewGable added the Daily KSv2 label Jun 5, 2024
@AndrewGable
Copy link
Contributor

Seems like a daily bug, not a deploy blocker. We should fix but don't think we need to block deploy on this. Assigning the relevant members

@VickyStash
Copy link
Contributor

As I mentioned in this comment it's an expected result to have only Pay as an individual option for now. Other options will be implemented in the future. For example, there is a separate issue for the Pay as business option implementation.

@ikevin127
Copy link
Contributor

Given this information, I think it's safe to say that we can close this out as NAB nor a regression.

@cristipaval Most likely you have even more context on this new UI / functionality and would be able confirm on this.

@cristipaval
Copy link
Contributor

yes, this is expected for now. An upcoming PR will add one more option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants