Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense - Inconsistency in showing last digits as 0 when spliting, submitting and paying #43214

Closed
6 tasks done
lanitochka17 opened this issue Jun 6, 2024 · 5 comments
Closed
6 tasks done
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.80-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4600954
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat
  3. Click + > Split expense > Manual
  4. Enter amount without digits after decimal point
  5. Tap Next
  6. Return to previous page via back button
  7. Note that xx.00 is not shown in the amount input
  8. Repeat Step 3 to 7 with Submit expense and Pay

Expected Result:

There should be consistency in displaying last digits as 0 when returning from confirmation page to amount input page when splitting, submitting and paying someone

Actual Result:

When spliting and submitting expense, amount is not auto-filled with .00 when returning to amount input page
When paying someone, amount is auto-filled with .00 when returning to amount input page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504236_1717697011634.20240607_015540.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@dangrous
Copy link
Contributor

dangrous commented Jun 6, 2024

This is likely coming from #40062 - we decided that we should keep user input as is, even if it shows differently in the summary page, so IMO no bug - just new expected behavior.

But if you disagree let us know and we can discuss!

@luacmartins
Copy link
Contributor

I couldn't reproduce the issue and I also don't think this is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants