Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chats are showing wrong current time of the user chatting with #43438

Closed
1 of 6 tasks
m-natarajan opened this issue Jun 10, 2024 · 11 comments
Closed
1 of 6 tasks

Chats are showing wrong current time of the user chatting with #43438

m-natarajan opened this issue Jun 10, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.81-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @RachCHopkins
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717991929286819

Action Performed:

Precondition : user A and user B are in different timezones

  1. User A sent a message to user B
  2. Observe the timestamp of the chat as user B

Expected Result:

Should show the time of user A

Actual Result:

Showing the user B time in PST, after switching to another chat and coming back shows correct time

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-06-10_15-54-22

Screenshot 2024-06-10 at 12 14 34 PM

Screenshot 2024-06-10 at 12 11 29 PM

Recording.202.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 10, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 10, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@NikkiWines
Copy link
Contributor

I'm not able to reliably reproduce, nor is @luacmartins from this thread.

@RachCHopkins
Copy link
Contributor

@NikkiWines I'm finding for me the Social keeps switching to PST. I wonder if changing your timezone for a week might surface it?

@NikkiWines
Copy link
Contributor

NikkiWines commented Jun 11, 2024

@RachCHopkins is this happening on staging only or staging and production? I'll test by modifying my own timezone now

@NikkiWines
Copy link
Contributor

NikkiWines commented Jun 11, 2024

Not a deploy blocker - reproducible on prod for a while now

@NikkiWines NikkiWines added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Jun 11, 2024
@bernhardoj
Copy link
Contributor

The pusher always sends the LA timezone data to the user when receiving the message.
image

@tgolen
Copy link
Contributor

tgolen commented Jun 12, 2024

I see it coming from the response to AddComment, so I think this is a backend issue.

image

I'm not sure exactly what it takes to reproduce it, but I've had it happen twice today. If I go into my settings, the timezone is correct for me, and then when I return to the chat, the timestamps are correct again.

After a little bit of chatting, the timestamps then revert to PST.

@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2024
@NikkiWines
Copy link
Contributor

Fairly certain this issue is a dupe of #43032, which shows almost identical behavior. I think we should close this one out in favor of that one.

cc: @MonilBhavsar since you've been able to reproduce this bug.

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2024
@MonilBhavsar
Copy link
Contributor

Feel free to. There are three issues now, I'll go ahead and remove "Needs reproduction" label on the other issue 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants