-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Import #43533
Comments
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
Triggered auto assignment to @isabelastisser ( |
Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue! |
Update: |
Thanks for your update 👍 |
I'll be starting to work on this task tomorrow as I'm almost done with the Sage Intacct connection task. |
@yuwenmemon, @hungvu193, @isabelastisser, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Can we put this on hold for #43532 🤔 so it won't get overdue |
@SzymczakJ sounds like he'll be working on it tomorrow so no need to put a HOLD IMO. |
Update: Started working on this, PR draft should be around in one/two days. |
Update: still working on draft PR. By the way how is backend for this task looking? If I call |
@yuwenmemon @hungvu193 can you please follow up on the question above? Thanks! |
I think it should be similar with QBO and Xero. Let's wait for confirmation from Yuwen |
@SzymczakJ As mentioned in the Design Doc we'll actually be adding individual API commands for each setting, which will require separate action method in the front-end. They're described in detail in the doc I linked above. As for when they'll be available on production I believe @NikkiWines is actively working on the issue right now so I expect we start seeing them next week. In the meantime let's build out the actions and use the descriptions of the APIs in the Design Doc so that it's plug-and-play when the APIs go live. |
Still working on it |
@yuwenmemon, @hungvu193, @isabelastisser, @SzymczakJ Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Still In progress |
Same |
I should be able to take this PR out of draft on Monday. |
PR will be ready for review today. |
I got a review from @war-in, let me fix his comments and tomorrow the PR will be ready for your review @hungvu193 😄 |
PR ready for review. When testing keep in mind that some functionalities don't work and wait to be fixed on BE side:
|
Also ready for design team review. The visual part is presented in test steps of PR. |
Thank you. I'll take a look today :🙋♂️ |
@hungvu193, can you please provide an update? Thanks! |
PR is merged, I think the automation is failing it doesn't update issue title |
Thanks for the heads up, @hungvu193! Payment summary: @hungvu193 C+ role, $250, payment pending in ND. All set! |
No payment needed for me as SageIntacct project will be paid centrally 😄 |
Tracking GH: https://github.com/Expensify/Expensify/issues/388780
Design doc section: https://docs.google.com/document/d/1k3ZFw8KB55yPUSCG6KYZlwpwEtmRt3eUshwxs7bZq5I/edit#heading=h.vc9skc4t3y4f
You will find in the following issue the pseudocode for the different flows. Use them as a guide in your implementation.
Import flow
Main page
Issue Owner
Current Issue Owner: @hungvu193The text was updated successfully, but these errors were encountered: