[$250] mWeb - Chat - Emoji picker cut off in the bottom

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to New Expensify
2. Navigate to any chat
3. Open emoji picker

Expected Result:

Emoji picker should be fully rendered to the very bottom of the screen

Actual Result:

Emoji picker is cut off in the bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512117_1718293278184.Record_2024-06-13-17-17-32.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015d3ee2fb419bfdb5
• Upwork Job ID: 1801295914996738899
• Last Price Increase: 2024-06-13

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015d3ee2fb419bfdb5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[mountiny]

This does not feel like a blocker to me, feel free to change that but demoting

[daledah]

Please re-state the problem that we are trying to solve in this issue.

Emoji picker is cut off in the bottom

What is the root cause of that problem?

In here , We added an extra View without any style when we added FocusTrap before.

What changes do you think we should make in order to solve the problem?

We can fix this bug by Remove the extra View

App/src/components/Modal/BaseModal.tsx

Line 256 in 361a000

<View>

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @daledah! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rayane-djouah]

@daledah - It looks like the extra View is necessary, see https://github.com/Expensify/App/pull/39520/files#r1634713582

[rayane-djouah]

Offending PR: #39520

[rayane-djouah]

Looking for better proposals

[rayane-djouah]

@deetergp - Can you please add Bug label? Thanks

[daledah]

@rayane-djouah I think this issue has been fixed in this PR

[rayane-djouah]

Yes, it is fixed. We can close this one @deetergp

[rayane-djouah]

Thank you for your help @daledah